-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: WASM_ENABLED=1 for all platforms #3416
build: WASM_ENABLED=1 for all platforms #3416
Conversation
cac023a
to
a13db96
Compare
a13db96
to
7a8e20b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just questions.
a9e3345
to
f9700ca
Compare
d0bd2bc
to
d3260f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes
|
||
release-build-darwin: | ||
name: Release Build (darwin) | ||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👉 https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
macos-latest
is 10.15, not big sur. But the binaries work on the latter, too.
Downloading the gcc for mingw32 on the fly still lets the linux+windows build finish under 3 minutes. I'd say we look into a builder image if this proves to be brittle or annoying. |
I guess as long as no one is using |
e24d5e9
to
0dcadf1
Compare
a100d1f
to
71c3182
Compare
Squashed and ready to go. 🏁 |
2941b53
to
7e903bb
Compare
aef679f
to
b94f0ba
Compare
env: | ||
TELEMETRY_URL: ${{ secrets.TELEMETRY_URL }} | ||
run: make release-local | ||
- name: Download release binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own understanding...whereas before we would build the OPA binaries here, now they will be built above by release-build
and release-build-darwin
and then downloaded here. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
b94f0ba
to
416b3d9
Compare
6401c9c
to
600ce9b
Compare
Notes: - If there are other users of the 'build-windows' make target they would likely be annoyed by the change that's now apt-get'ting packages - We could build a builder image instead of installing the package every time. - ci-go-*: run as root now, so we're able to install the packages for windows. - tests: skip tests that depend on not being run as root when root. The change to ci-go-* makes that necessary; the impact is rather limited right now. We can reconsider if there are more tests depending on not being run as root. - build: add '-buildmode=exe' to GOFLAGS Primarily for the windows build, but I don't think it should be wrong for the others either: golang/go#40795 See https://golang.org/cmd/go/#hdr-Build_modes: > -buildmode=exe > Build the listed main packages and everything they import into > executables. Packages not named main are ignored. - go: fix version as 1.16.3 This was discussed in this PR, but not the other one. We'd rather keep this an exact match. - build: update go module related env vars With 1.16, https://blog.golang.org/go116-module-changes, > The go command now builds packages in module-aware mode by default. Also, since we've added the `go 1.15` directive to go.mod, we can drop all -mod=vendor flags, https://golang.org/ref/mod#go-mod-file-go, > At go 1.14 or higher, automatic vendoring may be enabled. If the file > vendor/modules.txt is present and consistent with go.mod, there is no > need to explicitly use the -mod=vendor flag. - build: replace build-docker by build-linux Turns out the binaries were identical now. - workflow: adapt github workflows - build: override docker id/gid in 'image' target, to keep existing behaviour. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
split linux and windows to not wait for the windows build to finish before starting the npm-opa-wasm tests. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Fixes open-policy-agent#3264. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
600ce9b
to
8ff54c2
Compare
This was approved, and rebased -- will squash and merge when green. |
This PR had a spurious "waiting for status to be reported" right from the start, but it's actually all green now: https://github.com/open-policy-agent/opa/actions/runs/813799167 |
Notes:
If there are other users of the 'build-windows' make target they would
likely be annoyed by the change that's now apt-get'ting packages
We could build a builder image instead of installing the package every
time.
ci-go-*: run as root now, so we're able to install the packages for
windows.
tests: skip tests that depend on not being run as root when root. The
change to ci-go-* makes that necessary; the impact is rather limited
right now. We can reconsider if there are more tests depending on not
being run as root.
build: add '-buildmode=exe' to GOFLAGS
Primarily for the windows build, but I don't think it should be wrong
for the others either:
cmd/link: "x86_64-w64-mingw32/bin/ld.exe: Error: export ordinal too large" after upgrading to Go 1.15 golang/go#40795
See https://golang.org/cmd/go/#hdr-Build_modes:
go: bump to 1.16.3, keep compat with 1.15
See https://golang.org/ref/mod#go-mod-file-go about the
go
directive ingo.mod
:build: update go module related env vars
With 1.16, https://blog.golang.org/go116-module-changes,
Also, since we've added the
go 1.15
directive to go.mod, we can dropall -mod=vendor flags, https://golang.org/ref/mod#go-mod-file-go,
build: replace build-docker by build-linux
Turns out the binaries were identical now.
workflow: adapt github workflows
build: override docker id/gid in 'image' target, to keep existing
behaviour.
References: