fix: Fixing the issue of the object.subset method failing to correctly compare array relationships #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCRUNNN
force-pushed
the
bugfix/object_subset_arrays
branch
from
67ce70d
to
c231f85
Compare
…y compare array relationships relative issue：[https://github.com/open-policy-agent/opa/issues/5968]#5968 1. modify arraySubset method，fixing the incorrect assignment of `superElem` and adding array boundary checks 2. add testcases for the code change --bug=[https://github.com/open-policy-agent/opa/issues/5968]#5968 Signed-off-by: DCRUNNN <458891338@qq.com>
1. fixing the incorrect assignment of `superElem` and adding array boundary checks 2. add testcases for the code change --bug=[https://github.com/open-policy-agent/opa/issues/5968]#5968 Signed-off-by: DCRUNNN <458891338@qq.com>
…y compare array relationships > > relative issue：[https://github.com/open-policy-agent/opa/issues/5968]#5968 > > 1. modify arraySubset method，fixing the incorrect assignment of `superElem` and adding array boundary checks > 2. add testcases for the code change > > --bug=[https://github.com/open-policy-agent/opa/issues/5968]#5968 > > Signed-off-by: DCRUNNN <458891338@qq.com> Signed-off-by: DCRUNNN <458891338@qq.com>
DCRUNNN
force-pushed
the
bugfix/object_subset_arrays
branch
from
c231f85
to
8514386
Compare
johanfylling
approved these changes
Jun 5, 2023
| return false | ||
| } | ||
|
|
||
| subElem := sub.Elem(subCursor) | ||
| superElem := sub.Elem(superCursor + subCursor) |
There was a problem hiding this comment.
Huh? Wow, this must have produced a fair share of false positives 😬.
ashutosh-narkar
pushed a commit
to ashutosh-narkar/opa
that referenced
this pull request
Jun 5, 2023
…y compare array relationships (open-policy-agent#5969) Fixes：open-policy-agent#5968 Signed-off-by: DCRUNNN <458891338@qq.com> (cherry picked from commit b97ee9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fixing the issue of the object.subset method failing to correctly compare array relationships
relative issue：#5968
superElemand adding array boundary checks--bug=#5968
PTAL