-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(download): add opa_no_oci flag to build without containerd #6159
feat(download): add opa_no_oci flag to build without containerd #6159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed it. Let's collect more input and see if an ideal solution -- removing containerd while keeping the functionality -- would be another option... 😃
As Stephan mentioned, removing the containerd dependency would be ideal. A cursory look at the OCI code makes me think we should be able to do that. @DerGut wdyt? That of course would be more involved but could be better from a maintenance pov. The approach in this PR seems fine. I guess we could have additional such flags in the future to control functionality which does not sound ideal. |
Hey @DerGut 👋 - would love your input on this by the end of this week. We have a release planed next week so would love to know if this could be merged by then or not. |
Hi @slonka and @ashutosh-narkar I'm having a look now. I try to give a response by tomorrow 👍 |
It definitely seems possible to remove We can use the remote.Repository type to pass it to the oras.Copy call. I've played around with it a little bit but couldn't yet get all tests to pass. To integrate our authentication plugins with oras's auth interface, more in-depth understanding would be needed. @slonka if you need to cut a release by the end of the week, I'd suggest to merge this PR first and iterate on removing |
Let's call it out as temporary in the release notes (or omit it), though -- if the containerd dep was gone, there's no need anymore to disable the functionality; so we could revert this in the future. |
@slonka can you please squash your commits and we can then get this in. Thanks! |
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: slonka <slonka@users.noreply.github.com>
b83341b
to
da4a505
Compare
@ashutosh-narkar the tests seem to be flaky (different ones fail on the same changes) - can you re-run them? |
The test failures are not related to your changes. We're looking into it. |
105946a
into
open-policy-agent:main
@ashutosh-narkar - last question: is it safe for us to use |
xrel #6160
Why the changes in this PR are needed?
I think it's best explained in the issue - #6160
What are the changes in this PR?
This pr adds an
opa_no_oci
build flag to exclude containerd dependency.Notes to assist PR review:
Look at the issue first - #6160.
Further comments:
Nothing.