Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Address issues with Ecosystem links in navs #6200

Merged

Conversation

charlieegan3
Copy link
Contributor

There are the following issues with the docs menus at the moment:

  • OPA ecosystem is shown 2x for some versions
  • OPA ecosystem is not linked from the mobile nav in the latest version
  • OPA ecosystem still appears under misc in earlier versions
Screenshot 2023-08-31 at 10 32 26 Screenshot 2023-08-31 at 10 25 57

In order to make changes based on page structure in earlier versions, I've had to filter how the pages are selected. I've opted to exclude all content based linking to the opa ecosystem and replace it with the hardcoded link to the now unversioned page /ecosystem.

The mobile enterprise support link has also been renamed to match the link text used on the desktop sidenav

@charlieegan3 charlieegan3 marked this pull request as ready for review August 31, 2023 09:37
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 411d744
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/64f088229ebce40008cc80e5
😎 Deploy Preview https://deploy-preview-6200--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Charlie Egan <charlie@styra.com>
@charlieegan3 charlieegan3 merged commit 65a8b7d into open-policy-agent:main Aug 31, 2023
19 checks passed
@charlieegan3 charlieegan3 deleted the docs-ecosystem-nav-fix branch August 31, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants