-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to marshal location text #6234
Merged
charlieegan3
merged 5 commits into
open-policy-agent:main
from
charlieegan3:include-location-text
Sep 21, 2023
Merged
Add option to marshal location text #6234
charlieegan3
merged 5 commits into
open-policy-agent:main
from
charlieegan3:include-location-text
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
Sep 20, 2023
charlieegan3
force-pushed
the
include-location-text
branch
from
September 20, 2023 10:44
74a496b
to
69cb413
Compare
charlieegan3
force-pushed
the
include-location-text
branch
from
September 20, 2023 10:52
69cb413
to
77c59fb
Compare
srenatus
reviewed
Sep 20, 2023
srenatus
previously approved these changes
Sep 20, 2023
srenatus
previously approved these changes
Sep 20, 2023
charlieegan3
force-pushed
the
include-location-text
branch
from
September 20, 2023 13:22
4e21371
to
7e1a296
Compare
Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
This was failing the linter Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
include-location-text
branch
from
September 21, 2023 08:21
7e1a296
to
b4b2bcd
Compare
srenatus
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅
Thanks Stephan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6213
Here is an example of who this change impacts the output of
opa parse
. Updating the options inopa parse
is not required as part of this PR since it's mainly intended for Go API users. However, I felt that it might make sense to include all the location data for now and see what others thought.