Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic metadata object in docs #6709

Conversation

antonioberben
Copy link
Contributor

Simple fix in the documentation.

Dynamic Metadata should be a key-value json object like: {"my-new-metadata": "my-new-value"}
In the docs it is: {"foo", "bar"}

Signed-off-by: Antonio Berben <antonio.berben@solo.io>
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit b8cdcd4
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/6630b2600c1044000806bb1e
😎 Deploy Preview https://deploy-preview-6709--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonioberben antonioberben force-pushed the fix-dynamic-metadata-documentation branch from 566bc13 to 67367fd Compare April 23, 2024 13:30
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The docs say it's an object, so this change seems correct to me, but there's also a later section after "With the input value above, the value of all the variables in the package are:" where this is displayed as a set/array, so you'd need to change it there too for this to be consistent.

@antonioberben
Copy link
Contributor Author

@anderseknert , where can I find that? the line is this one, but I can't find where the source is

@antonioberben
Copy link
Contributor Author

Hi @anderseknert , can you point me to the file I have to change? I cannot find it. Thanks!

@anderseknert
Copy link
Member

@antonioberben sorry for the delay! I had somehow missed your first ping. On closer inspection I see that the code block I was referring to is auto-generated from the input and policy, and when I check the netlify preview it looks like it should. I'm sorry about that! All good then 👍

@anderseknert anderseknert merged commit 7ec4d58 into open-policy-agent:main Apr 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants