-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic metadata object in docs #6709
Fix dynamic metadata object in docs #6709
Conversation
Signed-off-by: Antonio Berben <antonio.berben@solo.io>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
566bc13
to
67367fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The docs say it's an object, so this change seems correct to me, but there's also a later section after "With the input value above, the value of all the variables in the package are:" where this is displayed as a set/array, so you'd need to change it there too for this to be consistent.
@anderseknert , where can I find that? the line is this one, but I can't find where the source is |
Hi @anderseknert , can you point me to the file I have to change? I cannot find it. Thanks! |
@antonioberben sorry for the delay! I had somehow missed your first ping. On closer inspection I see that the code block I was referring to is auto-generated from the input and policy, and when I check the netlify preview it looks like it should. I'm sorry about that! All good then 👍 |
Simple fix in the documentation.
Dynamic Metadata should be a key-value json object like:
{"my-new-metadata": "my-new-value"}
In the docs it is:
{"foo", "bar"}