qemu: force --with kvmonly as default behavior
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but let's make sure the build passes |
Since CentOS 7.5, sgabios-bin is not provided in the os/ repository. This arose an issue in our qemu.spec, which mistakenly builds qemu-system-x86 on ppc64 architecture. This patch assumes `--with kvmonly` as the default behavior, which won't build qemu-system-x86 anymore; and also fixes some non-x86 files packaging. Even though we're forcing `--with kvmonly`, we still provide qemu-system-ppc package for compatibility reasons.
Update qemu deps.
mopsfelder
force-pushed
the
devel/drop-qemu-system-x86
branch
from
12156c7
to
11bf03a
Compare
|
The reason why CI is failing is not related to the changes of this pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CentOS 7.5, sgabios-bin is not provided in the os/ repository. This arose
an issue in our qemu.spec, which mistakenly builds qemu-system-x86 on ppc64
architecture.
This patch assumes
--with kvmonlyas the default behavior, which won't buildqemu-system-x86 anymore; and also fixes some non-x86 files packaging.
Even though we're forcing
--with kvmonly, we still provide qemu-system-ppcpackage for compatibility reasons.