Fixing logic error #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file has quite a few cpp core guideline violations. In this case, it appears to be doing manual pointer arithmetic, without an end bound, which is explicitly disallowed and ideally should be handled by rnage checked. This commit does not attempt to fix all the issues, but simply fixes the compiler error such that the OpenBMC rebase can continue without hitting this compiler error. In this case, the check appears to be checking a pointer operation against nullptr, which is somewhat nonsensical, as a pointer incremented by an offset is nearly always going to be non nullptr. What I suspect his code was attempting to do was to see if the end of the string, passed by a null terminated character was equal to null, ie '\0'. This commit changes the logic to do as I suspect the author intended, which will allow the build to succeed. Tested: Code compiles in latest openbmc rebase. No guard system available to test functionality. Signed-off-by: Ed Tanous <edtanous@google.com>
|
I agree @edtanous, I think the length should be a parameter to the constructor. I will check and change it. Thanks for pointing it out |
devenrao
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue found by OpenBMC on latest version of gcc.