Skip to content

Commit 69de20e

Browse files
vanderpop-jenkins
authored andcommitted
This reverts the stop 1 commits
Change-Id: I351f8c6568540642eec0f95e6d7b3edea79e6a24 Original-Change-Id: Iddb6f734b8c05b97fc4d87268829ecb7af08fdf2 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40653 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: YUE DU <daviddu@us.ibm.com> Dev-Ready: Gregory S. Still <stillgs@us.ibm.com> Reviewed-by: Michael S. Floyd <mfloyd@us.ibm.com> Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
1 parent 51a2d2a commit 69de20e

File tree

1 file changed

+18
-21
lines changed

1 file changed

+18
-21
lines changed

import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -380,16 +380,18 @@ p9_cme_stop_entry()
380380
out32(CME_LCL_SICR_OR, core_stop1 << SHIFT32(1));
381381
out32(CME_LCL_SICR_CLR, core_stop1 << SHIFT32(1));
382382

383-
// Removed: Do not want users to become accustomed to seeing Stop1 reflected in Stop History on DD1
384-
//
385-
//PK_TRACE("Update STOP history: in core stop level 1");
386-
//scom_data.words.lower = 0;
387-
//scom_data.words.upper = SSH_ACT_LV1_COMPLETE;
388-
//CME_PUTSCOM(PPM_SSHSRC, core_stop1, scom_data.value);
389-
//
383+
PK_TRACE("Update STOP history: in core stop level 1");
384+
scom_data.words.lower = 0;
385+
scom_data.words.upper = SSH_ACT_LV1_COMPLETE;
386+
CME_PUTSCOM(PPM_SSHSRC, core_stop1, scom_data.value);
390387

391388
core = core & ~core_stop1;
392389

390+
if (!core)
391+
{
392+
break;
393+
}
394+
393395
#else
394396

395397
// Nap should be done by hardware when auto_stop1 is enabled
@@ -401,6 +403,10 @@ p9_cme_stop_entry()
401403

402404
}
403405

406+
//----------------------------------------------------------------------
407+
PK_TRACE("+++++ +++++ STOP LEVEL 2 ENTRY +++++ +++++");
408+
//----------------------------------------------------------------------
409+
404410
#if HW405292_NDD1_PCBMUX_SAVIOR
405411

406412
p9_cme_pcbmux_savior_prologue(core);
@@ -411,6 +417,7 @@ p9_cme_stop_entry()
411417
out32(CME_LCL_SICR_OR, core << SHIFT32(11));
412418

413419
// Poll Infinitely for PCB Mux Grant
420+
// MF: change watchdog timer in pk to ensure forward progress
414421
while((core & (in32(CME_LCL_SISR) >> SHIFT32(11))) != core);
415422

416423
PK_TRACE("PCB Mux Granted on Core[%d]", core);
@@ -421,20 +428,6 @@ p9_cme_stop_entry()
421428

422429
#endif
423430

424-
#if HW386841_NDD1_DSL_STOP1_FIX
425-
426-
// exit after getting PCBMUX for Stop1 Workaround
427-
if (!core)
428-
{
429-
break;
430-
}
431-
432-
#endif
433-
434-
//----------------------------------------------------------------------
435-
PK_TRACE("+++++ +++++ STOP LEVEL 2 ENTRY +++++ +++++");
436-
//----------------------------------------------------------------------
437-
438431
// set target_level from pm_state for both cores or just one core
439432
target_level = (core == CME_MASK_C0) ? G_cme_stop_record.req_level[0] :
440433
G_cme_stop_record.req_level[1];
@@ -571,6 +564,7 @@ p9_cme_stop_entry()
571564
while((lclr_data & core) != core);
572565

573566
// Waits quiesce done for at least 512 core cycles
567+
// MF: verify generate FCB otherwise math is wrong.
574568
PPE_WAIT_CORE_CYCLES(512)
575569

576570
PK_TRACE_INF("SE.2B: Interfaces Quiesced");
@@ -699,6 +693,9 @@ p9_cme_stop_entry()
699693
PK_PANIC(CME_STOP_ENTRY_STOPCLK_FAILED);
700694
}
701695

696+
// MF: verify compiler generate single rlwmni
697+
// MF: delay may be needed for stage latch to propagate thold
698+
702699
PK_TRACE_INF("SE.2C: Core Clock Stopped");
703700

704701
//==============================

0 commit comments

Comments
 (0)