guest/generate: change --append option to be a boolean based on presence #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-power#65. Currently, the -a --append option accepts a string to be parsed into an integer, either 0 or 1. This integer is then used to set a boolean append flag. Avoid parsing strings at all by having the boolean append flag be set to true if -a/--append exists, otherwise default to false. NOTE: This does introduce a change in the command line API. Signed-off-by: Eric Richter <erichte@linux.ibm.com>
|
I think the API breakage is worth the fix. I agree with your argument. Though we really need to add a test for this flag being properly applied in our test suite. As always, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65.
Currently, the -a --append option accepts a string to be parsed into an integer, either 0 or 1. This integer is then used to set a boolean append flag.
Avoid parsing strings at all by having the boolean append flag be set to 1 if -a/--append exists, otherwise default to 0.
NOTE: This does introduce a change in the command line API.
This one is a slightly more invasive change, but I think the removal of needless string parsing is better for overall safety. Please let me know if you disagree with this approach.