-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit unbundling the library #190
Comments
This should be possible by letting However, I do not have time to make the required changes to do this right now. I would review and potentially merge a PR, but it would also need to expand CI to cover these new build scenarios. |
Thank you. Unfortunately I do not have any Rust experience, so I'll not be able to assist you with this. |
I took a quick glance at this out of curiosity, but liboqs doesn't seem to provide a pkg-config file, and cmake scripts alone aren't easily read from |
Now that @tranzystorek-io provided open-quantum-safe/liboqs#1435 which was merged (thank you!!!), I think the discussion should continue here. @thomwiggers are there any specific requirements for such a PR? So far I only got
|
This should be fixed by #190 right? |
@thomwiggers This here is issue #190, so I'm not sure what you meant to link. |
My bad, #211 |
I am currently trying to write a FreeBSD port (i.e. distribution package) for the rosenpass project. In the process of doing that I noticed that it bundles a static copy of liboqs through your crate. This is unfortunate. We would strongly prefer if the project instead linked against
liboqs.so
so we can fix potential security issues in a single place.Would it be possible for you to permit linking against a shared library instead of building and linking your own static copy of the code?
The text was updated successfully, but these errors were encountered: