Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unwanted error left in queue from OBJ_create #404

Merged
merged 1 commit into from
May 8, 2024

Conversation

bencemali
Copy link
Contributor

OBJ_create can leave an unwanted error on the error stack.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! LGTM -- but please rebase to main once #410 has landed to have CI pass before we can merge.

@baentsch
Copy link
Member

baentsch commented May 8, 2024

Please rebase to latest main to get CI to pass. Please also note that LinuxFoundation requires all contributions to be "signed" (git commit option "-s") such as to ascertain their legal rights to all code: no further contributions are permitted without contributors agreeing to this ("DCO test" to pass: Click on failed status above to get information how to resolve this). I also don't like this but it's the price we have to pay to hopefully get more corporate contributors in the project.

Signed-off-by: Bence Mali <bence.mali@tresorit.com>
@baentsch baentsch merged commit 6ae3eca into open-quantum-safe:main May 8, 2024
30 checks passed
@baentsch
Copy link
Member

baentsch commented May 8, 2024

Thanks for rebase / DCO. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants