Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Nielsen deoxyfluorination dataset #110

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

michaelmaser
Copy link
Contributor

Dataset created from notebook in ord-schema by @connorcoley.

connorcoley and others added 2 commits July 14, 2021 09:29
…-reaction-database#114)

* Expt2 10.1021/acs.accounts.0c00760 (open-reaction-database#100)

* Add files via upload

* Delete Figure4_dataset.pbtxt

* Uploading Data for 10.1021/acs.accounts.0c00760

* Add files via upload

Co-authored-by: Steven Kearnes <kearnes@google.com>

* Update submission

* Update badges

Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com>
Co-authored-by: Steven Kearnes <kearnes@google.com>
Co-authored-by: github-actions <github-actions@github.com>
* bump ord-schema version

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
@skearnes
Copy link
Contributor

skearnes commented Jul 21, 2021

Thanks @michaelmaser! A few comments:

  • The SI says "8 x 40 mm" glass vial; should this be included somewhere? I assume the 1 mL annotation is inferred from that size?
  • Add volume_includes_solutes = False to the solvents (including in the workup)?
  • The chloroform added in the workup should be deuterated (also update the corresponding description).
  • The non-synthesized SFs (PyFluor and PBSF) should be indicated in build_compound.
  • The vendor for PyFluor should be specified.
  • Please add the names of the SFs so the records are easier to read.
  • The logic to build out the table doesn't seem to correctly copy preparations (I expected to see SYNTHESIZED for the randomly chosen reaction shown in the notebook).

@michaelmaser
Copy link
Contributor Author

Thanks, @skearnes! Think I got everything. Added a record_modified for posterity.

@skearnes
Copy link
Contributor

Thanks, @skearnes! Think I got everything. Added a record_modified for posterity.

Thanks! Would you mind attaching the updated notebook---or linking to a PR on ord-schema with the changes?

@michaelmaser
Copy link
Contributor Author

Thanks! Would you mind attaching the updated notebook---or linking to a PR on ord-schema with the changes?

Sure thing, attached here. Happy to create a PR, maybe next office hours.
example_nielsen.ipynb.zip

@skearnes
Copy link
Contributor

Thanks! One more question: where is the stereochemistry information coming from for e.g. 1a in the example reaction? I don't see that in the SI or paper anywhere?

@skearnes
Copy link
Contributor

Thanks! One more question: where is the stereochemistry information coming from for e.g. 1a in the example reaction? I don't see that in the SI or paper anywhere?

Nevermind; was looking at the wrong structure.

@michaelmaser
Copy link
Contributor Author

Thanks! Any idea why the check_file_types is failing?

@skearnes
Copy link
Contributor

I think it's because the target branch is out of date, and the job does a comparison vs. main. If you update nielsen it should work, but I wouldn't worry about it.

@michaelmaser
Copy link
Contributor Author

Worked, thanks!

@michaelmaser michaelmaser merged commit 2604983 into open-reaction-database:nielsen Jul 28, 2021
michaelmaser added a commit that referenced this pull request Jul 28, 2021
* Adds Nielsen deoxyfluorination dataset (#110)

* Adds Nielsen deoxyfluorination dataset

* Expt2 10.1021/acs.accounts.0c00760 (#100) (#114)

* Expt2 10.1021/acs.accounts.0c00760 (#100)

* Add files via upload

* Delete Figure4_dataset.pbtxt

* Uploading Data for 10.1021/acs.accounts.0c00760

* Add files via upload

Co-authored-by: Steven Kearnes <kearnes@google.com>

* Update submission

* Update badges

Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com>
Co-authored-by: Steven Kearnes <kearnes@google.com>
Co-authored-by: github-actions <github-actions@github.com>

* Update DOI list (#111)

* bump ord-schema version

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Addresses review comments

* Addresses review comments

Co-authored-by: Connor Coley <connorcoley@users.noreply.github.com>
Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com>
Co-authored-by: Steven Kearnes <kearnes@google.com>
Co-authored-by: github-actions <github-actions@github.com>

* Update submission

* Update badges

Co-authored-by: Connor Coley <connorcoley@users.noreply.github.com>
Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com>
Co-authored-by: Steven Kearnes <kearnes@google.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants