-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Nielsen deoxyfluorination dataset #110
Adds Nielsen deoxyfluorination dataset #110
Conversation
…-reaction-database#114) * Expt2 10.1021/acs.accounts.0c00760 (open-reaction-database#100) * Add files via upload * Delete Figure4_dataset.pbtxt * Uploading Data for 10.1021/acs.accounts.0c00760 * Add files via upload Co-authored-by: Steven Kearnes <kearnes@google.com> * Update submission * Update badges Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com> Co-authored-by: Steven Kearnes <kearnes@google.com> Co-authored-by: github-actions <github-actions@github.com>
* bump ord-schema version * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
Thanks @michaelmaser! A few comments:
|
Thanks, @skearnes! Think I got everything. Added a |
Thanks! Would you mind attaching the updated notebook---or linking to a PR on ord-schema with the changes? |
Sure thing, attached here. Happy to create a PR, maybe next office hours. |
Thanks! One more question: where is the stereochemistry information coming from for e.g. 1a in the example reaction? I don't see that in the SI or paper anywhere? |
Nevermind; was looking at the wrong structure. |
Thanks! Any idea why the check_file_types is failing? |
I think it's because the target branch is out of date, and the job does a comparison vs. |
Worked, thanks! |
* Adds Nielsen deoxyfluorination dataset (#110) * Adds Nielsen deoxyfluorination dataset * Expt2 10.1021/acs.accounts.0c00760 (#100) (#114) * Expt2 10.1021/acs.accounts.0c00760 (#100) * Add files via upload * Delete Figure4_dataset.pbtxt * Uploading Data for 10.1021/acs.accounts.0c00760 * Add files via upload Co-authored-by: Steven Kearnes <kearnes@google.com> * Update submission * Update badges Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com> Co-authored-by: Steven Kearnes <kearnes@google.com> Co-authored-by: github-actions <github-actions@github.com> * Update DOI list (#111) * bump ord-schema version * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Addresses review comments * Addresses review comments Co-authored-by: Connor Coley <connorcoley@users.noreply.github.com> Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com> Co-authored-by: Steven Kearnes <kearnes@google.com> Co-authored-by: github-actions <github-actions@github.com> * Update submission * Update badges Co-authored-by: Connor Coley <connorcoley@users.noreply.github.com> Co-authored-by: mwleklin <44303709+mwleklin@users.noreply.github.com> Co-authored-by: Steven Kearnes <kearnes@google.com> Co-authored-by: github-actions <github-actions@github.com>
Dataset created from notebook in ord-schema by @connorcoley.