Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle deleted files #574

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

skearnes
Copy link
Collaborator

@skearnes skearnes commented Mar 9, 2021

Fixes #569

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #574 (56c1be4) into main (cad41f7) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   76.07%   76.28%   +0.21%     
==========================================
  Files          18       18              
  Lines        1881     1881              
  Branches      467      467              
==========================================
+ Hits         1431     1435       +4     
+ Misses        301      300       -1     
+ Partials      149      146       -3     
Impacted Files Coverage Δ
ord_schema/scripts/process_dataset.py 82.23% <100.00%> (+2.63%) ⬆️

@skearnes skearnes merged commit d4c0f48 into open-reaction-database:main Mar 9, 2021
@skearnes skearnes deleted the deleted branch March 9, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process_dataset.py is not correctly handling deleted files
2 participants