Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addition device types, and analysis types #719

Merged
merged 10 commits into from
May 17, 2024

Conversation

FanwangM
Copy link
Collaborator

@FanwangM FanwangM commented May 13, 2024

This PR suppresses #718. The git history is retained to reflect the contributions of @bdeadman.
There are two issues with the original PR:

  • linting errors because of missing white space, differences between 2 white spaces and 4 spaces, and lines getting too long (fixed);
  • all the protobuf py and js files need to be updated once the schema gets changed

Other changes:

  • The actions/checkout is also updated to v4;
  • The license header is updated to 2024.

This PR addresses #607 and #708.

@bdeadman
Copy link
Collaborator

Thanks @FanwangM. I'll have a proper look and review it tomorrow night when I'm back at a computer.

Copy link
Collaborator

@bdeadman bdeadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FanwangM. PR approved.

@bdeadman bdeadman merged commit ba63b97 into open-reaction-database:main May 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants