Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/center on infra #851

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Hammer/center on infra #851

merged 2 commits into from
Nov 30, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Nov 29, 2023

What's new

  • Centers on lift
  • Centers on door
center-2023-11-29_17.26.28.mp4

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 621 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (b34a881) 27.29%.
Report is 30 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 163 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 41 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 37 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 28 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 12 Missing ⚠️
packages/dashboard/src/components/doors-app.tsx 0.00% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #851       +/-   ##
==================================================
- Coverage          49.35%   27.29%   -22.06%     
==================================================
  Files                285      157      -128     
  Lines               7564     5096     -2468     
  Branches            1050     1225      +175     
==================================================
- Hits                3733     1391     -2342     
+ Misses              3682     3525      -157     
- Partials             149      180       +31     
Flag Coverage Δ
api-server ?
dashboard 14.05% <4.29%> (-1.02%) ⬇️
react-components 45.87% <21.16%> (-2.21%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
LGTM!

@aaronchongth aaronchongth merged commit 9004748 into deploy/hammer Nov 30, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/center-on-infra branch November 30, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants