Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs / minimal CI update for Humble #215

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Conversation

luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Sep 8, 2022

Bug fix

Fixed bug

Yet another doc / CI update for Humble! Minimal version to avoid introducing too much changes i.e. in the docker build workflow.

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova marked this pull request as ready for review September 8, 2022 08:37
@luca-della-vedova
Copy link
Member Author

luca-della-vedova commented Sep 8, 2022

Nightly fail is due to it trying to build the simulation / demos packages after the rename but the renaming PRs not being merged yet.

If there is any further issue with the nightly builds after the renaming it will be addressed in a future PR.

Error below for reference:

2022-09-08T07:38:44.8650293Z Package 'rmf_building_sim_gz_plugins' specified with --packages-up-to was not found
2022-09-08T07:38:44.8651315Z Package 'rmf_building_sim_gz_classic_plugins' specified with --packages-up-to was not found
2022-09-08T07:38:44.8652294Z Package 'rmf_robot_sim_gz_plugins' specified with --packages-up-to was not found
2022-09-08T07:38:44.8652927Z Package 'rmf_robot_sim_gz_classic_plugins' specified with --packages-up-to was not found
2022-09-08T07:38:44.8653864Z Package 'rmf_demos_gz_classic' specified with --packages-up-to was not found
2022-09-08T07:38:44.9024823Z + package_paths=
2022-09-08T07:38:44.9030969Z ##[endgroup]
2022-09-08T07:38:44.9054465Z ##[error]The process '/usr/bin/bash' failed with exit code 1

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@orensbruli
Copy link
Contributor

orensbruli commented Sep 9, 2022

her issue with the nightly builds after the renaming it will be addressed in a future P

For reference open-rmf/rmf_demos#155 Is it only needed the sign-off of the last commit to getting it merged?

@luca-della-vedova luca-della-vedova merged commit ee7edc3 into main Sep 13, 2022
@luca-della-vedova luca-della-vedova deleted the luca/humble-image-v2 branch September 13, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants