Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate nav graphs for CleanerBotA and CleanerBotE #10

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

Yadunund
Copy link
Member

Bug fix

Fixed bug

Previously both cleaning fleets shared the same traffic map and hence nav graph which included 4 cleaning zones. CleanerBotA was configured to clean all four zones but CleanerBotE, only zones 2, 3 & 4. But this constraint was enforced by the way the DockSummary message was being populated by the mock_docker node. However, a user could submit a loop request with start waypoint as zone_1 which could then get assigned to CleanerBotE as the waypoint exists in its nav graph (same nav graph). When the robot enters the lanes with zone_1, it would begin docking process at which stage the robot will be stuck forever (as mock_docker cannot find the list of docking waypoints for zone_1 for CleanerBotE).

Fix applied

Separated nav graphs for the two fleets.

Nav graph for CleanerBotA (deleted lanes that access charging points of CleanerBotE)
image

Nav graph for CleanerBotE (deleted lanes that access zone_1 and charger point of CleanerBotA)
image

Also disabled loop requests for both fleets.

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@youliangtan youliangtan merged commit a02ba39 into main Mar 22, 2021
@youliangtan youliangtan deleted the fix/cleaning_demo branch March 22, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants