Separate nav graphs for CleanerBotA and CleanerBotE #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Previously both cleaning fleets shared the same traffic map and hence nav graph which included 4 cleaning zones. CleanerBotA was configured to clean all four zones but CleanerBotE, only zones 2, 3 & 4. But this constraint was enforced by the way the DockSummary message was being populated by the
mock_docker
node. However, a user could submit aloop
request with start waypoint aszone_1
which could then get assigned toCleanerBotE
as the waypoint exists in its nav graph (same nav graph). When the robot enters the lanes withzone_1
, it would begin docking process at which stage the robot will be stuck forever (asmock_docker
cannot find the list of docking waypoints forzone_1
for CleanerBotE).Fix applied
Separated nav graphs for the two fleets.
Nav graph for CleanerBotA (deleted lanes that access charging points of CleanerBotE)
Nav graph for CleanerBotE (deleted lanes that access
zone_1
and charger point of CleanerBotA)Also disabled
loop
requests for both fleets.