-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rmf_demos_panel #235
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@@ -54,29 +54,6 @@ By specifying `server_uri`, the fleetadapter will update `rmf-web` `api-server` | |||
* [Campus World](#Campus-World) | |||
* [Manufacturing & Logistics World](#Manufacturing-&-Logistics-World) | |||
|
|||
**RMF Panel** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can instead direct users to rmf-web
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rmf-web
is already introduced just before this paragraph, so that would be a bit redundant
@aaronchongth could you comment on whether |
yup Meanwhile, it might be a better idea to have it's own repo, or be an orphan branch in edit: added an orphan branch for this package, https://github.com/open-rmf/rmf_demos/tree/rmf-web-dashboard-resources |
@luca-della-vedova I guess we can get rid of |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Done! ab3ade1 |
* Remove rmf_demos_panel Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Readme for dashboard resources Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> * Remove rmf_demos_dashboard_resources Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> --------- Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai> Co-authored-by: Yadu <yadunund@intrinsic.ai>
Fixes #234
Remove
rmf_demos_panel
and all its mentions. I can't quite placermf_demos_dashboard_resources
, it seems it still can be used to generate configurations forrmf-web
but it hasn't seen updates in some time. For example, its CMakeLists doesn't include some of the newer maps (i.e. campus)