Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rmf_demos_panel #235

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Remove rmf_demos_panel #235

merged 5 commits into from
Jun 11, 2024

Conversation

luca-della-vedova
Copy link
Member

Fixes #234

Remove rmf_demos_panel and all its mentions. I can't quite place rmf_demos_dashboard_resources, it seems it still can be used to generate configurations for rmf-web but it hasn't seen updates in some time. For example, its CMakeLists doesn't include some of the newer maps (i.e. campus)

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@Yadunund Yadunund mentioned this pull request Jun 4, 2024
@Yadunund Yadunund self-assigned this Jun 4, 2024
@@ -54,29 +54,6 @@ By specifying `server_uri`, the fleetadapter will update `rmf-web` `api-server`
* [Campus World](#Campus-World)
* [Manufacturing & Logistics World](#Manufacturing-&-Logistics-World)

**RMF Panel**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can instead direct users to rmf-web here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmf-web is already introduced just before this paragraph, so that would be a bit redundant

@Yadunund
Copy link
Member

Yadunund commented Jun 4, 2024

@aaronchongth could you comment on whether rmf_demos_dashboard_resources resources is still used in rmf-web?

@aaronchongth
Copy link
Member

aaronchongth commented Jun 5, 2024

yup rmf_demos_dashboard_resources can be used in rmf-web. If the intention is to release all packages from rmf_demos, it doesn't need to be released. I'll redirect users to use the one in the humble branch, so this can be removed in main.

Meanwhile, it might be a better idea to have it's own repo, or be an orphan branch in rmf_demos too

edit: added an orphan branch for this package, https://github.com/open-rmf/rmf_demos/tree/rmf-web-dashboard-resources

@Yadunund
Copy link
Member

edit: added an orphan branch for this package, https://github.com/open-rmf/rmf_demos/tree/rmf-web-dashboard-resources

@luca-della-vedova I guess we can get rid of rmf_demos_dashboard_resources now?

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@luca-della-vedova
Copy link
Member Author

Done! ab3ade1

@Yadunund Yadunund merged commit 9146198 into main Jun 11, 2024
3 checks passed
@Yadunund Yadunund deleted the luca/remove_panel branch June 11, 2024 17:51
xiyuoh pushed a commit that referenced this pull request Jun 25, 2024
* Remove rmf_demos_panel

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Readme for dashboard resources

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

* Remove rmf_demos_dashboard_resources

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>

---------

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Co-authored-by: Yadu <yadunund@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop rmf_demos_panel from main
3 participants