Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/geojson graph #142

Merged
merged 31 commits into from
Feb 13, 2022
Merged

Feature/geojson graph #142

merged 31 commits into from
Feb 13, 2022

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Nov 22, 2021

Beginnings of GeoJSON support. Goes with open-rmf/rmf_traffic_editor#403 to provide a conversion function from SiteMap messages that contain GeoJSON (compressed or uncompressed) and rmf_traffic graph data structures. Builds off work by @luca-della-vedova which prototyped GeoPackage.

luca-della-vedova and others added 19 commits September 10, 2021 19:27
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #142 (1453302) into main (d3e6a55) will decrease coverage by 0.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   21.19%   20.41%   -0.78%     
==========================================
  Files         214      796     +582     
  Lines       17441    67764   +50323     
  Branches     8232    32080   +23848     
==========================================
+ Hits         3696    13833   +10137     
- Misses       9786    38872   +29086     
- Partials     3959    15059   +11100     
Flag Coverage Δ
tests 20.41% <ø> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...raffic_ros2/src/rmf_traffic_ros2/schedule/Node.cpp
...s2/src/rmf_traffic_ros2/schedule/convert_Query.cpp
...c_ros2/schedule/convert_ParticipantDescription.cpp
...raffic_ros2/src/rmf_traffic_ros2/blockade/Node.cpp
...rmf_traffic_ros2/src/rmf_traffic_blockade/main.cpp
...mock_participants/repetitive_delay_participant.cpp
...k_ros2/src/rmf_task_ros2/bidding/MinimalBidder.cpp
...2/rmf_fleet_adapter_python/src/planner/planner.cpp
...mf_rxcpp/include/rmf_rxcpp/detail/RxJobsDetail.hpp
...c_ros2/src/rmf_traffic_ros2/convert_Trajectory.cpp
... and 1000 more

@codebot
Copy link
Contributor Author

codebot commented Nov 22, 2021

Tested on the main "big" demos in https://github.com/open-rmf/rmf_demos

Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova added this to In Review in Research & Development via automation Nov 23, 2021
@mxgrey mxgrey self-requested a review November 25, 2021 02:05
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
mxgrey
mxgrey previously approved these changes Feb 11, 2022
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
mxgrey and others added 3 commits February 13, 2022 01:11
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
Co-authored-by: Morgan Quigley <morgan@osrfoundation.org>
@mxgrey mxgrey merged commit 3e52711 into main Feb 13, 2022
Research & Development automation moved this from In Review to Done Feb 13, 2022
@mxgrey mxgrey deleted the feature/geojson_graph branch February 13, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants