Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit / Diagnostic tool #61

Open
4 of 5 tasks
mxgrey opened this issue Oct 4, 2022 · 1 comment · Fixed by #154
Open
4 of 5 tasks

Audit / Diagnostic tool #61

mxgrey opened this issue Oct 4, 2022 · 1 comment · Fixed by #154
Assignees
Labels
enhancement New feature or request

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Oct 4, 2022

Provide a tool that looks for common mistakes or potential issues within the site data. The user would be provided with a list of warnings with advice on how to fix it.

In the event that the user wants to ignore certain warnings, they could click a button to suppress an item in the list. That suppression will be saved to their site file so it is remembered next time. There would also be a way to view what warnings have been suppressed from inside the GUI.

Some examples of possible warnings:

  • Two anchors are very close to each other but not connected
  • Multiple doors/lifts/models share the same name
  • Multiple docks have the same name, or a reverse dock has the same name as its forward dock
  • A door/lift/model is using the default name value
  • A fiducial is missing its label

Feel free to comment with suggestions for more diagnostics.

@mxgrey mxgrey added the enhancement New feature or request label Oct 4, 2022
@luca-della-vedova luca-della-vedova self-assigned this Jul 17, 2023
@luca-della-vedova
Copy link
Member

Together with the fiducials with no name, there are several issues currently captured by warn messages in the (future) drawing editor mode that could be changed to be captured by this tool, such as:

  • Building has multiple levels but < 2 matching fiducials between the reference level and each of the other ones. Site editor would fail to perform level alignment.
  • < 2 constraints found between the level drawing and a robot map, same issue as above when optimizing transforms.

We could potentially also do additional validation on the navgraph, for example make sure that there is at least one charger location per graph id, to avoid robots being unable to charge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants