Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct order of req/res uri for event emitter #191

Merged
merged 1 commit into from
Jul 17, 2020
Merged

fix: correct order of req/res uri for event emitter #191

merged 1 commit into from
Jul 17, 2020

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented Jul 17, 2020 •
edited
Loading

fixes #190
fixes #188

@shanejonas shanejonas requested a review from zcstarr July 17, 2020 00:24
@shanejonas shanejonas self-assigned this Jul 17, 2020
@shanejonas shanejonas added the bug Something isn't working label Jul 17, 2020
@shanejonas shanejonas force-pushed the fix/event-emitter-input-output branch from 0e6445e to 0f9e511 Compare July 17, 2020 00:25
@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited
Loading

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          10       10           
  Lines         365      365           
  Branches       46       53    +7     
=======================================
  Hits          363      363           
  Misses          2        2
Impacted Files Coverage Δ
src/transports/EventEmitterTransport.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131a4fc...0e5ca00. Read the comment docs.

@shanejonas shanejonas force-pushed the fix/event-emitter-input-output branch from 0f9e511 to fa2ae94 Compare July 17, 2020 00:27
@shanejonas shanejonas force-pushed the fix/event-emitter-input-output branch from fa2ae94 to 0e5ca00 Compare July 17, 2020 00:33
@shanejonas shanejonas mentioned this pull request Jul 17, 2020
Closed
@shanejonas shanejonas merged commit c578870 into master Jul 17, 2020
@shanejonas shanejonas deleted the fix/event-emitter-input-output branch July 17, 2020 03:28
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcstarr zcstarr zcstarr approved these changes

Assignees

@shanejonas shanejonas

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventEmitter reqUri/resUri are backwards EventEmitterTransport not parsing response either throwing error
3 participants
@shanejonas @openrpc-bastion @zcstarr