Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

params by-name keys are incorrectly mapped #670

Closed
shanejonas opened this issue Jul 17, 2021 · 1 comment · Fixed by #671 · May be fixed by HaLaGu1L/execution-apis#5
Closed

params by-name keys are incorrectly mapped #670

shanejonas opened this issue Jul 17, 2021 · 1 comment · Fixed by #671 · May be fixed by HaLaGu1L/execution-apis#5
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Member

the _.zipObject lodash api expects (props, values) but the values are swapped:

generator/src/components/client.ts

Line 141 in 25761a8

rpcParams = _.zipObject(params, _.map(methodObject.params, "name"));

@shanejonas shanejonas added the bug Something isn't working label Jul 17, 2021
shanejonas added a commit that referenced this issue Jul 17, 2021
@shanejonas
fix: lodash zipObject wrong order
5c1a1ef 
fixes #670
@shanejonas shanejonas mentioned this issue Jul 17, 2021
Merged
openrpc-bastion added a commit that referenced this issue Jul 17, 2021
@openrpc-bastion
chore(release): 1.20.1 [skip ci]
51de273 
## [1.20.1](1.20.0...1.20.1) (2021-07-17)

### Bug Fixes

* lodash zipObject wrong order ([5c1a1ef](5c1a1ef)), closes [#670](#670)
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HaLaGu1L HaLaGu1L mentioned this issue Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@shanejonas @openrpc-bastion