Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: unable to edit date on editing a highlight (Safari Only) #1144

Closed
1 of 2 tasks
0-vortex opened this issue May 4, 2023 · 8 comments · Fixed by #1962
Closed
1 of 2 tasks

Bug: unable to edit date on editing a highlight (Safari Only) #1144

0-vortex opened this issue May 4, 2023 · 8 comments · Fixed by #1962
Assignees
Labels
Milestone

Comments

@0-vortex
Copy link
Contributor

0-vortex commented May 4, 2023

Describe the bug

Screen.Recording.2023-05-04.at.22.14.25.mov

Steps to reproduce

  1. Add a new highlight without date
  2. Edit highlight and try to set date

Affected services

insights.opensauced.pizza

Platforms

No response

Browsers

No response

Environment

Production, Development, Testing

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@0-vortex 0-vortex added 🐛 bug Something isn't working 👀 needs triage labels May 4, 2023
@0-vortex
Copy link
Contributor Author

0-vortex commented May 4, 2023

@OgDev-01 Knowing you have worked on implementing the date picker, do you happen to know if this bug is a duplicate of any existing issue? 😅

@OgDev-01
Copy link
Contributor

So I tried to replicate this issue from my end...
https://www.loom.com/share/2f39f0bd7d15456ea64f3bbc0898c4c9

It works as expected on other browsers except Safari... I'll look into this for a possible fix 👍

@OgDev-01 OgDev-01 changed the title Bug: unable to edit date on editing a highlight Bug: unable to edit date on editing a highlight (Safari Only) May 16, 2023
@bdougie bdougie assigned diivi and unassigned OgDev-01 Aug 4, 2023
@diivi
Copy link
Contributor

diivi commented Aug 4, 2023

I'm on ubuntu and almost all alternatives I tried to safari ended up being either too old or ruining other elements of the website too:
image

If someone knows how to run safari on Linux, I can work on this.

@0-vortex
Copy link
Contributor Author

0-vortex commented Aug 4, 2023

If someone knows how to run safari on Linux, I can work on this.

Most online tutorials will use wine to install safari version 5 (2010) on linux - in my humble opinion, that is a waste of time and would not recommend trying 🍕

@diivi diivi removed their assignment Aug 4, 2023
@nickytonline
Copy link
Member

I did a quick test in Safari and if you click quickly multiple times, you'll see it open very briefly and close. I tried recording it, but for some reason it didn't get picked up.

There's also no errors in the console on Safari. The fact that it opens and closes so quickly leads me to believe the state of a hook is somehow triggering in invalid ways.

@OgDev-01
Copy link
Contributor

OgDev-01 commented Oct 20, 2023

After our pair session yestersday @nickytonline , all solutions to resolve this had hit a dead end, and i'll open an issue on the radix primitive repo for this if i don't see a related one...

I'll move on with the solution we found (manually handling the popover state with react useState) as a fix for now

Update:
found a related issue in radix-ui/primitives#2348. seems they haven’t been a fix for safari yet

@open-sauced
Copy link
Contributor

open-sauced bot commented Oct 23, 2023

🎉 This issue has been resolved in version 1.72.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced
Copy link
Contributor

open-sauced bot commented Oct 24, 2023

🎉 This issue has been resolved in version 1.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants