feat: implement insights team feature #1080

OgDev-01 · 2023-04-05T19:58:21Z

What type of PR is this? (check all applicable)

Description

This PR:

Adds teams invite, update and delete implementation
refactors the select options to accept objects with name and value key pairs

Note:

The select needs a bit of work to be responsive atm... It overflows on mobile. We need to replace the select with Radix select that we already have in the design system. I'll open an issue on this to refactor the current radix implementation

Related Tickets & Documents

Closes #975

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-04-05T19:58:27Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`9afe063`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/643edb01354c450008229dec
😎 Deploy Preview	https://deploy-preview-1080--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-04-05T19:58:30Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`9afe063`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/643edb01073b280008c7da89
😎 Deploy Preview	https://deploy-preview-1080--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandonroberts · 2023-04-07T15:28:12Z

@OgDev-01 the user/owner has been added to the insight information https://beta.api.opensauced.pizza/#/Insights%20service/findInsightPageById

…75-team-feat

brandonroberts · 2023-04-17T16:04:20Z

@OgDev-01 there's a build failure on the deploy preview

OgDev-01 · 2023-04-17T16:09:09Z

@OgDev-01 there's a build failure on the deploy preview

Fixed ✅

nightknighto · 2023-04-18T00:32:46Z

For some reason my name is displayed as undefined.

components/molecules/FilterCardSelect/filter-card-select.tsx

components/molecules/TeamMemberRow/team-member-row.tsx

components/molecules/TeamMembersConfig/team-members-config.tsx

OgDev-01 · 2023-04-18T16:07:36Z

For some reason my name is displayed as undefined.

@brandonroberts any idea why this would occur?

brandonroberts · 2023-04-18T16:14:23Z

For some reason my name is displayed as undefined.

@brandonroberts any idea why this would occur?

The user doesn't have a name defined in the database

We should fallback to the login if its not defined

OgDev-01 · 2023-04-18T18:02:58Z

@Deadreyo can you test again to confirm the undefined issue has been handled?

nightknighto

Yeah it is fixed now. LGTM! 🚀

brandonroberts

LGTM

bdougie

Functionally checked it out and works for me.

## [1.43.0-beta.2](v1.43.0-beta.1...v1.43.0-beta.2) (2023-04-18) ### 🍕 Features * implement insights team feature ([#1080](#1080)) ([5186a60](5186a60))

github-actions · 2023-04-18T21:03:55Z

🎉 This PR is included in version 1.43.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.43.0](v1.42.0...v1.43.0) (2023-04-20) ### 🍕 Features * add page to accept insight member invitation ([#1102](#1102)) ([ffe35e2](ffe35e2)) * connect contributor page and graphs to the API ([#1072](#1072)) ([#1112](#1112)) ([4fc471c](4fc471c)) * connect contributors page to API ([#1113](#1113)) ([e51c51e](e51c51e)) * implement insights team feature ([#1080](#1080)) ([5186a60](5186a60)) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](#1089)) ([83d89bd](83d89bd)), closes [#1057](#1057) * only redirect on contributor profile if login is defined ([#1114](#1114)) ([483f38c](483f38c))

github-actions · 2023-04-20T20:37:01Z

🎉 This PR is included in version 1.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.43.0-beta.2](open-sauced/app@v1.43.0-beta.1...v1.43.0-beta.2) (2023-04-18) ### 🍕 Features * implement insights team feature ([#1080](open-sauced/app#1080)) ([5186a60](open-sauced/app@5186a60))

## [1.43.0](open-sauced/app@v1.42.0...v1.43.0) (2023-04-20) ### 🍕 Features * add page to accept insight member invitation ([#1102](open-sauced/app#1102)) ([ffe35e2](open-sauced/app@ffe35e2)) * connect contributor page and graphs to the API ([#1072](open-sauced/app#1072)) ([#1112](open-sauced/app#1112)) ([4fc471c](open-sauced/app@4fc471c)) * connect contributors page to API ([#1113](open-sauced/app#1113)) ([e51c51e](open-sauced/app@e51c51e)) * implement insights team feature ([#1080](open-sauced/app#1080)) ([5186a60](open-sauced/app@5186a60)) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](open-sauced/app#1089)) ([83d89bd](open-sauced/app@83d89bd)), closes [#1057](open-sauced/app#1057) * only redirect on contributor profile if login is defined ([#1114](open-sauced/app#1114)) ([483f38c](open-sauced/app@483f38c))

intial commit for this PR

d03766d

OgDev-01 added 3 commits April 6, 2023 21:29

chore: update db types

8e70e61

feat: create insight members hook

e381c0f

chore: copy text updates and fix insights data error

2c2b907

OgDev-01 added 16 commits April 10, 2023 15:34

chore: validate email

9ba88c6

Merge branch 'beta' of https://github.com/open-sauced/insights into 9…

0a28784

…75-team-feat

feat: setup team invite

2d3489d

feat: add teams hook

a2008bf

Merge branch 'beta' of https://github.com/open-sauced/insights into 9…

a5548b0

…75-team-feat

feat: update member role implementation

14e12ce

chore: minor changes

b59bab4

refactor: improve search component

377b3c2

refactor: improve select filter for teams role

99960a8

feat: add toast for visual feedback

8b92d73

chore: update teams crud

35eb88a

refactor: minor adjustments

b4849d2

fix: linting errors

d5f923e

fix: select tick visibility

e3d97ee

Merge branch 'beta' of https://github.com/open-sauced/insights into 9…

ffc079c

…75-team-feat

refactor: minor adjustments

634c310

OgDev-01 mentioned this pull request Apr 17, 2023

refactor: update implementation of current select to be more flexible in usage #1101

Closed

2 tasks

OgDev-01 added 2 commits April 17, 2023 16:56

fix: build error

7f4b33d

fix: update teams story

1f49082

OgDev-01 marked this pull request as ready for review April 17, 2023 16:07

OgDev-01 requested a review from nightknighto April 17, 2023 16:10

chore: review changes

df18bcc

nightknighto suggested changes Apr 18, 2023

View reviewed changes

components/molecules/FilterCardSelect/filter-card-select.tsx Outdated Show resolved Hide resolved

components/molecules/TeamMemberRow/team-member-row.tsx Outdated Show resolved Hide resolved

components/molecules/TeamMembersConfig/team-members-config.tsx Outdated Show resolved Hide resolved

OgDev-01 added 3 commits April 18, 2023 18:38

chore: review changes

571e273

fix: update story props

8226832

chore: review changes

9afe063

OgDev-01 requested review from nightknighto and brandonroberts April 18, 2023 18:03

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Apr 18, 2023

nightknighto approved these changes Apr 18, 2023

View reviewed changes

brandonroberts approved these changes Apr 18, 2023

View reviewed changes

brandonroberts added the needs-approval label Apr 18, 2023

bdougie approved these changes Apr 18, 2023

View reviewed changes

OgDev-01 added ready-to-merge and removed needs review PRs that need review from core engineering team needs-approval labels Apr 18, 2023

brandonroberts merged commit 5186a60 into beta Apr 18, 2023

brandonroberts deleted the 975-team-feat branch April 18, 2023 20:59

github-actions bot added the released on @beta label Apr 18, 2023

github-actions bot added the released label Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement insights team feature #1080

feat: implement insights team feature #1080

OgDev-01 commented Apr 5, 2023 •

edited

Loading

netlify bot commented Apr 5, 2023 •

edited

Loading

netlify bot commented Apr 5, 2023 •

edited

Loading

brandonroberts commented Apr 7, 2023 •

edited

Loading

brandonroberts commented Apr 17, 2023

OgDev-01 commented Apr 17, 2023

nightknighto commented Apr 18, 2023

OgDev-01 commented Apr 18, 2023

brandonroberts commented Apr 18, 2023 •

edited

Loading

OgDev-01 commented Apr 18, 2023

nightknighto left a comment •

edited

Loading

brandonroberts left a comment

bdougie left a comment

github-actions bot commented Apr 18, 2023

github-actions bot commented Apr 20, 2023

feat: implement insights team feature #1080

feat: implement insights team feature #1080

Conversation

OgDev-01 commented Apr 5, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Apr 5, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Apr 5, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

brandonroberts commented Apr 7, 2023 • edited Loading

brandonroberts commented Apr 17, 2023

OgDev-01 commented Apr 17, 2023

nightknighto commented Apr 18, 2023

OgDev-01 commented Apr 18, 2023

brandonroberts commented Apr 18, 2023 • edited Loading

OgDev-01 commented Apr 18, 2023

nightknighto left a comment • edited Loading

Choose a reason for hiding this comment

brandonroberts left a comment

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 18, 2023

github-actions bot commented Apr 20, 2023

OgDev-01 commented Apr 5, 2023 •

edited

Loading

netlify bot commented Apr 5, 2023 •

edited

Loading

netlify bot commented Apr 5, 2023 •

edited

Loading

brandonroberts commented Apr 7, 2023 •

edited

Loading

brandonroberts commented Apr 18, 2023 •

edited

Loading

nightknighto left a comment •

edited

Loading