fix: adds spacing to contributor highlights container #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdougie
changed the title
|
This works... But it will be better to add a |
Of course. I will update this to use space-y |
brandonroberts
approved these changes
Apr 13, 2023
brandonroberts
changed the title
brandonroberts
added
requested changes
merge conflicts
bdougie
commented
Apr 18, 2023
components/organisms/ContributorProfileTab/contributor-profile-tab.tsx
Outdated
Show resolved
Hide resolved
space-y only adds margin top. https://tailwind.build/classes/spacing/-space-y-1+%25_F+.-space-y-* Going to switch back to mb-6 and take the tech debt for now. |
bdougie
commented
Apr 19, 2023
components/organisms/ContributorProfileTab/contributor-profile-tab.tsx
Outdated
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
## [1.43.0-beta.3](v1.43.0-beta.2...v1.43.0-beta.3) (2023-04-20) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](#1089)) ([83d89bd](83d89bd)), closes [#1057](#1057) ### 🍕 Features * connect contributor page and graphs to the API ([#1072](#1072)) ([#1112](#1112)) ([4fc471c](4fc471c))
|
🎉 This PR is included in version 1.43.0-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
## [1.43.0](v1.42.0...v1.43.0) (2023-04-20) ### 🍕 Features * add page to accept insight member invitation ([#1102](#1102)) ([ffe35e2](ffe35e2)) * connect contributor page and graphs to the API ([#1072](#1072)) ([#1112](#1112)) ([4fc471c](4fc471c)) * connect contributors page to API ([#1113](#1113)) ([e51c51e](e51c51e)) * implement insights team feature ([#1080](#1080)) ([5186a60](5186a60)) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](#1089)) ([83d89bd](83d89bd)), closes [#1057](#1057) * only redirect on contributor profile if login is defined ([#1114](#1114)) ([483f38c](483f38c))
|
🎉 This PR is included in version 1.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.43.0-beta.3](open-sauced/app@v1.43.0-beta.2...v1.43.0-beta.3) (2023-04-20) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](open-sauced/app#1089)) ([83d89bd](open-sauced/app@83d89bd)), closes [#1057](open-sauced/app#1057) ### 🍕 Features * connect contributor page and graphs to the API ([#1072](open-sauced/app#1072)) ([#1112](open-sauced/app#1112)) ([4fc471c](open-sauced/app@4fc471c))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.43.0](open-sauced/app@v1.42.0...v1.43.0) (2023-04-20) ### 🍕 Features * add page to accept insight member invitation ([#1102](open-sauced/app#1102)) ([ffe35e2](open-sauced/app@ffe35e2)) * connect contributor page and graphs to the API ([#1072](open-sauced/app#1072)) ([#1112](open-sauced/app#1112)) ([4fc471c](open-sauced/app@4fc471c)) * connect contributors page to API ([#1113](open-sauced/app#1113)) ([e51c51e](open-sauced/app@e51c51e)) * implement insights team feature ([#1080](open-sauced/app#1080)) ([5186a60](open-sauced/app@5186a60)) ### 🐛 Bug Fixes * adds spacing to contributor highlights container ([#1089](open-sauced/app#1089)) ([83d89bd](open-sauced/app@83d89bd)), closes [#1057](open-sauced/app#1057) * only redirect on contributor profile if login is defined ([#1114](open-sauced/app#1114)) ([483f38c](open-sauced/app@483f38c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR addresses the spacing of highlights on contributor profiles. They seem to be on top of each other and my change is adding a simple
mt-6to the div.I am open to other suggestions, but trying to keep it simple for this.
Related Tickets & Documents
fix #1057
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?