-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only redirect on contributor profile if login is defined #1114
Conversation
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
## [1.43.0-beta.5](v1.43.0-beta.4...v1.43.0-beta.5) (2023-04-20) ### π Bug Fixes * only redirect on contributor profile if login is defined ([#1114](#1114)) ([483f38c](483f38c))
π This PR is included in version 1.43.0-beta.5 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.43.0](v1.42.0...v1.43.0) (2023-04-20) ### π Features * add page to accept insight member invitation ([#1102](#1102)) ([ffe35e2](ffe35e2)) * connect contributor page and graphs to the API ([#1072](#1072)) ([#1112](#1112)) ([4fc471c](4fc471c)) * connect contributors page to API ([#1113](#1113)) ([e51c51e](e51c51e)) * implement insights team feature ([#1080](#1080)) ([5186a60](5186a60)) ### π Bug Fixes * adds spacing to contributor highlights container ([#1089](#1089)) ([83d89bd](83d89bd)), closes [#1057](#1057) * only redirect on contributor profile if login is defined ([#1114](#1114)) ([483f38c](483f38c))
π This PR is included in version 1.43.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.43.0-beta.5](open-sauced/app@v1.43.0-beta.4...v1.43.0-beta.5) (2023-04-20) ### π Bug Fixes * only redirect on contributor profile if login is defined ([#1114](open-sauced/app#1114)) ([483f38c](open-sauced/app@483f38c))
## [1.43.0](open-sauced/app@v1.42.0...v1.43.0) (2023-04-20) ### π Features * add page to accept insight member invitation ([#1102](open-sauced/app#1102)) ([ffe35e2](open-sauced/app@ffe35e2)) * connect contributor page and graphs to the API ([#1072](open-sauced/app#1072)) ([#1112](open-sauced/app#1112)) ([4fc471c](open-sauced/app@4fc471c)) * connect contributors page to API ([#1113](open-sauced/app#1113)) ([e51c51e](open-sauced/app@e51c51e)) * implement insights team feature ([#1080](open-sauced/app#1080)) ([5186a60](open-sauced/app@5186a60)) ### π Bug Fixes * adds spacing to contributor highlights container ([#1089](open-sauced/app#1089)) ([83d89bd](open-sauced/app@83d89bd)), closes [#1057](open-sauced/app#1057) * only redirect on contributor profile if login is defined ([#1114](open-sauced/app#1114)) ([483f38c](open-sauced/app@483f38c))
What type of PR is this? (check all applicable)
Description
When navigating to a user who's not connected, they are redirected an
undefined/contributions
URLRelated Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?