Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect contributors page to API #1113

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

brandonroberts
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Populates contributors page list from pull request data
  • Updates dashboard contributors count
  • Updates navigtation tab count
  • Fixes bugs with data not being updated with range change
  • Deletes hooks no longer used

Known issues:

  • May show duplicates contributors based on pull request dates

To test in the PR deploy preview, on the Repositories or Contributors change the range to 3m

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screenshot with Prod API

image

image

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Apr 20, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit abafcce
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64418ee7c6d6e3000830e894
😎 Deploy Preview https://deploy-preview-1113--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 20, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit abafcce
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64418ee7932c900008544e13
😎 Deploy Preview https://deploy-preview-1113--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

Can't wait to see the database load and impact. ETL indexer should pick up on all missing last 30 days data by end of next week as well πŸ• πŸš€

@brandonroberts brandonroberts merged commit e51c51e into beta Apr 20, 2023
@brandonroberts brandonroberts deleted the feat-contributions-api branch April 20, 2023 19:47
github-actions bot pushed a commit that referenced this pull request Apr 20, 2023
## [1.43.0-beta.4](v1.43.0-beta.3...v1.43.0-beta.4) (2023-04-20)

### πŸ• Features

* connect contributors page to API ([#1113](#1113)) ([e51c51e](e51c51e))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.43.0-beta.4 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Apr 20, 2023
## [1.43.0](v1.42.0...v1.43.0) (2023-04-20)

### πŸ• Features

* add page to accept insight member invitation ([#1102](#1102)) ([ffe35e2](ffe35e2))
* connect contributor page and graphs to the API ([#1072](#1072)) ([#1112](#1112)) ([4fc471c](4fc471c))
* connect contributors page to API ([#1113](#1113)) ([e51c51e](e51c51e))
* implement insights team feature ([#1080](#1080)) ([5186a60](5186a60))

### πŸ› Bug Fixes

* adds spacing to contributor highlights container ([#1089](#1089)) ([83d89bd](83d89bd)), closes [#1057](#1057)
* only redirect on contributor profile if login is defined ([#1114](#1114)) ([483f38c](483f38c))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.43.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.43.0-beta.4](open-sauced/app@v1.43.0-beta.3...v1.43.0-beta.4) (2023-04-20)

### πŸ• Features

* connect contributors page to API ([#1113](open-sauced/app#1113)) ([e51c51e](open-sauced/app@e51c51e))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.43.0](open-sauced/app@v1.42.0...v1.43.0) (2023-04-20)

### πŸ• Features

* add page to accept insight member invitation ([#1102](open-sauced/app#1102)) ([ffe35e2](open-sauced/app@ffe35e2))
* connect contributor page and graphs to the API ([#1072](open-sauced/app#1072)) ([#1112](open-sauced/app#1112)) ([4fc471c](open-sauced/app@4fc471c))
* connect contributors page to API ([#1113](open-sauced/app#1113)) ([e51c51e](open-sauced/app@e51c51e))
* implement insights team feature ([#1080](open-sauced/app#1080)) ([5186a60](open-sauced/app@5186a60))

### πŸ› Bug Fixes

* adds spacing to contributor highlights container ([#1089](open-sauced/app#1089)) ([83d89bd](open-sauced/app@83d89bd)), closes [#1057](open-sauced/app#1057)
* only redirect on contributor profile if login is defined ([#1114](open-sauced/app#1114)) ([483f38c](open-sauced/app@483f38c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants