fix: Fix Accessibility issues in user's settings page - user/settings
#2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
approved these changes
Nov 8, 2023
open-sauced bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
### [1.74.1-beta.6](v1.74.1-beta.5...v1.74.1-beta.6) (2023-11-08) ### 🧑💻 Code Refactoring * add a default fallback to switch ([e757841](e757841)) * fix a11y for timezone dropdown ([25c6b84](25c6b84)) * fix a11y with textarea ([f3edac6](f3edac6)) * remove getSocialMediaPlatformName(url) ([c412f7f](c412f7f)) * remove platform variable and 'break' statements from switch statement ([a690ad9](a690ad9)) * replace discord label ([b3ad2d5](b3ad2d5)) * use a switch statement for social media platform detection ([7a11d1e](7a11d1e)) ### 🐛 Bug Fixes * add accessibility features to footer component ([#2038](#2038)) ([9e89214](9e89214)) * Fix Accessibility issues in user's settings page - `user/settings` ([#2050](#2050)) ([11bfd19](11bfd19))
open-sauced bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
## [1.75.0](v1.74.0...v1.75.0) (2023-11-09) ### 🧑💻 Code Refactoring * add a default fallback to switch ([e757841](e757841)) * fix a11y for timezone dropdown ([25c6b84](25c6b84)) * fix a11y with textarea ([f3edac6](f3edac6)) * remove getSocialMediaPlatformName(url) ([c412f7f](c412f7f)) * remove platform variable and 'break' statements from switch statement ([a690ad9](a690ad9)) * replace discord label ([b3ad2d5](b3ad2d5)) * use a switch statement for social media platform detection ([7a11d1e](7a11d1e)) ### 🍕 Features * add nprogress bar for page transition indication ([#2026](#2026)) ([828ca4d](828ca4d)) * implement list creation from insights contributors page ([#2005](#2005)) ([06ffa5d](06ffa5d)) * implemented edit list page ([#2044](#2044)) ([7ac402d](7ac402d)) * show most recent contributions for contributors instead of last 30 days ([#2068](#2068)) ([cec0435](cec0435)) ### 🐛 Bug Fixes * add accessibility features to footer component ([#2038](#2038)) ([9e89214](9e89214)) * added missing Inter font ([#2070](#2070)) ([4f11635](4f11635)) * added tooltips on legend for most active contributors graph where data is not available yet ([d6e392c](d6e392c)) * added tooltips on legend for most active contributors graph where data is not available yet ([#2084](#2084)) ([6e27449](6e27449)) * change accepted pr icon to merged pr icon ([#2057](#2057)) ([d83f854](d83f854)) * Fix Accessibility issues in user's settings page - `user/settings` ([#2050](#2050)) ([11bfd19](11bfd19)) * fix Insights dashboard cards styling ([#2066](#2066)) ([47f578c](47f578c)) * fixed keyboard navigation for pagination ([#2073](#2073)) ([e1f3804](e1f3804)) * make highlight card responsive ([#2043](#2043)) ([1a904f2](1a904f2)) * new highlight dialog ui breaks now fixed ([#2087](#2087)) ([ece155a](ece155a)) * removed unnecessary CTAs for creating new lists/insights ([#2075](#2075)) ([e1c5617](e1c5617)) * stats appear in tooltips now for most active contributors graph ([7e0200f](7e0200f)) * stats appear in tooltips now for most active contributors graph ([#2081](#2081)) ([747e022](747e022)) * styling details on chart tooltip ([#2091](#2091)) ([f8b432a](f8b432a)) * styling tweaks to header areas and box shadow tweaks ([#2058](#2058)) ([2ad5a3c](2ad5a3c)) * top contributor is now updated with filters in list graph ([#2080](#2080)) ([597ef8f](597ef8f)) * upgrade Sentry package to latest version, add middleware to ignored transactions ([#2098](#2098)) ([aca6526](aca6526))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing form labels in user's settings page -
user/settingsfor:- Bio text area,
- Time zone dropdown,
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #2045
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?