Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unnecessary CTAs for creating new lists/insights #2075

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Nov 8, 2023

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #2074

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2023-11-08 at 10 04 12

CleanShot 2023-11-08 at 10 06 21

After

CleanShot 2023-11-08 at 10 04 52

CleanShot 2023-11-08 at 10 06 49

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 8, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit b5576b5
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/654ba359e737e50008079c76
😎 Deploy Preview https://deploy-preview-2075--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit b5576b5
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/654ba359ee20c80008d60d5b
😎 Deploy Preview https://deploy-preview-2075--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now πŸ‘

@brandonroberts brandonroberts merged commit e1c5617 into beta Nov 8, 2023
18 checks passed
@brandonroberts brandonroberts deleted the nickytonline/cleanup-ctas-lists-insights branch November 8, 2023 15:59
open-sauced bot pushed a commit that referenced this pull request Nov 8, 2023
### [1.74.1-beta.5](v1.74.1-beta.4...v1.74.1-beta.5) (2023-11-08)

### πŸ› Bug Fixes

* added missing Inter font ([#2070](#2070)) ([4f11635](4f11635))
* fixed keyboard navigation for pagination ([#2073](#2073)) ([e1f3804](e1f3804))
* removed unnecessary CTAs for creating new lists/insights ([#2075](#2075)) ([e1c5617](e1c5617))
open-sauced bot pushed a commit that referenced this pull request Nov 9, 2023
## [1.75.0](v1.74.0...v1.75.0) (2023-11-09)

### πŸ§‘β€πŸ’» Code Refactoring

* add a default fallback to switch ([e757841](e757841))
* fix a11y for timezone dropdown ([25c6b84](25c6b84))
* fix a11y with textarea ([f3edac6](f3edac6))
* remove getSocialMediaPlatformName(url) ([c412f7f](c412f7f))
* remove platform variable and 'break' statements from switch statement ([a690ad9](a690ad9))
* replace discord label ([b3ad2d5](b3ad2d5))
* use a switch statement for social media platform detection ([7a11d1e](7a11d1e))

### πŸ• Features

* add nprogress bar for page transition indication ([#2026](#2026)) ([828ca4d](828ca4d))
* implement list creation from insights contributors page ([#2005](#2005)) ([06ffa5d](06ffa5d))
* implemented edit list page ([#2044](#2044)) ([7ac402d](7ac402d))
* show most recent contributions for contributors instead of last 30 days ([#2068](#2068)) ([cec0435](cec0435))

### πŸ› Bug Fixes

* add accessibility features to footer component ([#2038](#2038)) ([9e89214](9e89214))
* added missing Inter font ([#2070](#2070)) ([4f11635](4f11635))
* added tooltips on legend for most active contributors graph where data is not available yet ([d6e392c](d6e392c))
* added tooltips on legend for most active contributors graph where data is not available yet ([#2084](#2084)) ([6e27449](6e27449))
* change accepted pr icon to merged pr icon ([#2057](#2057)) ([d83f854](d83f854))
* Fix Accessibility issues in user's settings page - `user/settings` ([#2050](#2050)) ([11bfd19](11bfd19))
* fix Insights dashboard cards styling ([#2066](#2066)) ([47f578c](47f578c))
* fixed keyboard navigation for pagination ([#2073](#2073)) ([e1f3804](e1f3804))
* make highlight card responsive ([#2043](#2043)) ([1a904f2](1a904f2))
* new highlight dialog ui breaks now fixed ([#2087](#2087)) ([ece155a](ece155a))
* removed unnecessary CTAs for creating new lists/insights ([#2075](#2075)) ([e1c5617](e1c5617))
* stats appear in tooltips now for most active contributors graph ([7e0200f](7e0200f))
* stats appear in tooltips now for most active contributors graph ([#2081](#2081)) ([747e022](747e022))
* styling details on chart tooltip ([#2091](#2091)) ([f8b432a](f8b432a))
* styling tweaks to header areas and box shadow tweaks ([#2058](#2058)) ([2ad5a3c](2ad5a3c))
* top contributor is now updated with filters in list graph ([#2080](#2080)) ([597ef8f](597ef8f))
* upgrade Sentry package to latest version, add middleware to ignored transactions ([#2098](#2098)) ([aca6526](aca6526))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Remove large CTAs to create new Insights and Lists.
3 participants