Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch insight repos in parallel on insight pages #2496

Merged
merged 1 commit into from Jan 19, 2024

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Jan 18, 2024

Description

  • To improve page load speed, insight repositories are fetched separately from insight page information client-side.
  • For larger lists such as CNCF dashboards, this would cause a timeout when loading insight page with repository information attached
  • Minimal insight page information is still fetched server-side.
  • Loading these repositories client-side prevents timeouts from occurring and allows repositories to load data in parallel.

https://beta.app.opensauced.pizza/pages/bdougie/43/dashboard
https://beta.app.opensauced.pizza/pages/bdougie/172/dashboard

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Visit https://deploy-preview-2496--oss-insights.netlify.app/pages/bdougie/43/dashboard or https://deploy-preview-2496--oss-insights.netlify.app/pages/bdougie/172/dashboard
  2. Note page loads without a timeout

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts requested a review from a team January 18, 2024 22:19
Copy link

netlify bot commented Jan 18, 2024

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 06c0afd
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/65a9a40aaec1060008bfc11a
😎 Deploy Preview https://deploy-preview-2496--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 18, 2024

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 06c0afd
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/65a9a40a08f40e000778cd42
😎 Deploy Preview https://deploy-preview-2496--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️ :shipit:

@brandonroberts brandonroberts merged commit 6cb2f50 into beta Jan 19, 2024
21 checks passed
@brandonroberts brandonroberts deleted the feat-load-insight-repos branch January 19, 2024 17:18
open-sauced bot pushed a commit that referenced this pull request Jan 19, 2024
## [1.84.0-beta.3](v1.84.0-beta.2...v1.84.0-beta.3) (2024-01-19)

### πŸ• Features

* fetch insight repos in parallel on insight pages ([#2496](#2496)) ([6cb2f50](6cb2f50))
open-sauced bot pushed a commit that referenced this pull request Jan 25, 2024
## [1.84.0](v1.83.0...v1.84.0) (2024-01-25)

### πŸ• Features

* add search by repositories component for tracked repositories flow in workspaces ([#2490](#2490)) ([af53422](af53422))
* fetch insight repos in parallel on insight pages ([#2496](#2496)) ([6cb2f50](6cb2f50))
* flow for creating a new workspace ([#2461](#2461)) ([0518614](0518614))
* new styling for "Add again" section in create/edit insight page ([#2501](#2501)) ([45fbfda](45fbfda))
* search suggestions can be JSX or a string now ([#2489](#2489)) ([16cb804](16cb804))
* workspaces can manage tracked repositories now (search repos flow) ([#2502](#2502)) ([f286586](f286586))

### πŸ› Bug Fixes

* add missing skeleton loader for insights panel ([#2524](#2524)) ([ef39332](ef39332))
* fixed repo insights icon in app sidebar ([#2494](#2494)) ([536153b](536153b))
* make emoji pick more accessible ([#2412](#2412)) ([743eed9](743eed9))
* navigate to updated list after save ([#2517](#2517)) ([9bd9baa](9bd9baa))
* now if a workspace settings page has an error, the error page is shown ([#2523](#2523)) ([5241261](5241261))
* now the app sidebar no longer crashes the page ([#2506](#2506)) ([13d2e28](13d2e28))
* now the workspace creation uses the updated endpoint ([#2522](#2522)) ([0a6df82](0a6df82))
* pressing enter when focused on search input routes the page ([#2403](#2403)) ([0030b55](0030b55))

### πŸ€– Build System

* update release action to use open-sauced/release v2 ([#2529](#2529)) ([f513032](f513032))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants