Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now the workspace creation uses the updated endpoint #2522

Merged
merged 2 commits into from Jan 25, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Jan 24, 2024

Description

Now workspace creation takes only one call thanks to open-sauced/api#512.

This PR updates the creation flow to reflect that.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Relates to #2502
Relates to open-sauced/api#512

Mobile & Desktop Screenshots/Recordings

N/A

Steps to QA

  1. Ensure you're logged in
  2. Navigate to deploy-preview-2522--oss-insights.netlify.app/workspaces/new
  3. Fill in the required workspace info (name) and add some repositories to track.
  4. Create the workspace including adding tracked repositories and you'll be redirected to the workspace settings page.
  5. Notice the settings load with the basic workspace information and tracked repositories.

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 24, 2024

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 6833950
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/65b187216985f40008da8953
😎 Deploy Preview https://deploy-preview-2522--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2024

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 6833950
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/65b187217bb66e0008642fa5
😎 Deploy Preview https://deploy-preview-2522--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team January 24, 2024 21:42
@brandonroberts brandonroberts merged commit 0a6df82 into beta Jan 25, 2024
11 checks passed
@brandonroberts brandonroberts deleted the nickytonline/workspaces-creation-payload-update branch January 25, 2024 16:43
open-sauced bot pushed a commit that referenced this pull request Jan 25, 2024
## [1.84.0-beta.6](v1.84.0-beta.5...v1.84.0-beta.6) (2024-01-25)

### πŸ› Bug Fixes

* add missing skeleton loader for insights panel ([#2524](#2524)) ([ef39332](ef39332))
* navigate to updated list after save ([#2517](#2517)) ([9bd9baa](9bd9baa))
* now if a workspace settings page has an error, the error page is shown ([#2523](#2523)) ([5241261](5241261))
* now the workspace creation uses the updated endpoint ([#2522](#2522)) ([0a6df82](0a6df82))

### πŸ€– Build System

* update release action to use open-sauced/release v2 ([#2529](#2529)) ([f513032](f513032))
open-sauced bot pushed a commit that referenced this pull request Jan 25, 2024
## [1.84.0](v1.83.0...v1.84.0) (2024-01-25)

### πŸ• Features

* add search by repositories component for tracked repositories flow in workspaces ([#2490](#2490)) ([af53422](af53422))
* fetch insight repos in parallel on insight pages ([#2496](#2496)) ([6cb2f50](6cb2f50))
* flow for creating a new workspace ([#2461](#2461)) ([0518614](0518614))
* new styling for "Add again" section in create/edit insight page ([#2501](#2501)) ([45fbfda](45fbfda))
* search suggestions can be JSX or a string now ([#2489](#2489)) ([16cb804](16cb804))
* workspaces can manage tracked repositories now (search repos flow) ([#2502](#2502)) ([f286586](f286586))

### πŸ› Bug Fixes

* add missing skeleton loader for insights panel ([#2524](#2524)) ([ef39332](ef39332))
* fixed repo insights icon in app sidebar ([#2494](#2494)) ([536153b](536153b))
* make emoji pick more accessible ([#2412](#2412)) ([743eed9](743eed9))
* navigate to updated list after save ([#2517](#2517)) ([9bd9baa](9bd9baa))
* now if a workspace settings page has an error, the error page is shown ([#2523](#2523)) ([5241261](5241261))
* now the app sidebar no longer crashes the page ([#2506](#2506)) ([13d2e28](13d2e28))
* now the workspace creation uses the updated endpoint ([#2522](#2522)) ([0a6df82](0a6df82))
* pressing enter when focused on search input routes the page ([#2403](#2403)) ([0030b55](0030b55))

### πŸ€– Build System

* update release action to use open-sauced/release v2 ([#2529](#2529)) ([f513032](f513032))
@nickytonline nickytonline mentioned this pull request Feb 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants