fix: add missing skeleton loader for insights panel #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
changed the title
brandonroberts
approved these changes
Jan 25, 2024
bdougie
approved these changes
Jan 25, 2024
nickytonline
deleted the
nickytonline/add-loading-skeleton-for-insight-panel
branch
open-sauced bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
## [1.84.0-beta.6](v1.84.0-beta.5...v1.84.0-beta.6) (2024-01-25) ### 🐛 Bug Fixes * add missing skeleton loader for insights panel ([#2524](#2524)) ([ef39332](ef39332)) * navigate to updated list after save ([#2517](#2517)) ([9bd9baa](9bd9baa)) * now if a workspace settings page has an error, the error page is shown ([#2523](#2523)) ([5241261](5241261)) * now the workspace creation uses the updated endpoint ([#2522](#2522)) ([0a6df82](0a6df82)) ### 🤖 Build System * update release action to use open-sauced/release v2 ([#2529](#2529)) ([f513032](f513032))
open-sauced bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
## [1.84.0](v1.83.0...v1.84.0) (2024-01-25) ### 🍕 Features * add search by repositories component for tracked repositories flow in workspaces ([#2490](#2490)) ([af53422](af53422)) * fetch insight repos in parallel on insight pages ([#2496](#2496)) ([6cb2f50](6cb2f50)) * flow for creating a new workspace ([#2461](#2461)) ([0518614](0518614)) * new styling for "Add again" section in create/edit insight page ([#2501](#2501)) ([45fbfda](45fbfda)) * search suggestions can be JSX or a string now ([#2489](#2489)) ([16cb804](16cb804)) * workspaces can manage tracked repositories now (search repos flow) ([#2502](#2502)) ([f286586](f286586)) ### 🐛 Bug Fixes * add missing skeleton loader for insights panel ([#2524](#2524)) ([ef39332](ef39332)) * fixed repo insights icon in app sidebar ([#2494](#2494)) ([536153b](536153b)) * make emoji pick more accessible ([#2412](#2412)) ([743eed9](743eed9)) * navigate to updated list after save ([#2517](#2517)) ([9bd9baa](9bd9baa)) * now if a workspace settings page has an error, the error page is shown ([#2523](#2523)) ([5241261](5241261)) * now the app sidebar no longer crashes the page ([#2506](#2506)) ([13d2e28](13d2e28)) * now the workspace creation uses the updated endpoint ([#2522](#2522)) ([0a6df82](0a6df82)) * pressing enter when focused on search input routes the page ([#2403](#2403)) ([0030b55](0030b55)) ### 🤖 Build System * update release action to use open-sauced/release v2 ([#2529](#2529)) ([f513032](f513032))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a skeleton loader for the insights panel component used in the application sidebar.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #2525
Mobile & Desktop Screenshots/Recordings
CleanShot.2024-01-24.at.18.34.16.mp4
Steps to QA
N/A. You can test it out in Storybook.
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?