feat: Update Scatter Chart Legend #260

chadstewart · 2022-08-24T15:34:46Z

What type of PR is this? (check all applicable)

Description

This PR adds the feature of updating the scatter chart legend

Details:

Updated the Scatter Chart name because it was no longer a generic scatter chart.
The scatter chart is currently the percentage bus factor of a contributor over time of last contribution since today. For example, if has a bus factor of 50% and has contributed 17 days ago, they'd appear in the middle of the graph.

Related Tickets & Documents

Fixes #101

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2022-08-24T15:34:51Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`09e6c78`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/630a0e8358e4ff00070ed55d
😎 Deploy Preview	https://deploy-preview-260--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-08-24T15:36:06Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`09e6c78`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/630a0e830d02e30007bd58ba
😎 Deploy Preview	https://deploy-preview-260--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

chadstewart · 2022-08-25T17:48:55Z

@bdougie @pixelsbyeryc @0-vortex Quick question. Do we need the top part of the eChart from GitSense?

0-vortex · 2022-08-25T17:51:42Z

@bdougie @pixelsbyeryc @0-vortex Quick question. Do we need the top part of the eChart from GitSense?

Have no idea what you mean but judging by the question I would say yes! 😅

0-vortex · 2022-08-25T17:52:50Z

will check from desktop - the screenshot is unreadable on mobile :D

chadstewart · 2022-08-25T17:56:31Z

will check from desktop - the screenshot is unreadable on mobile :D

It shows the number of contributors for the week and a percentage based on that number vs. the total number of contributors. At least that's what I understand personally.

0-vortex · 2022-08-25T18:27:25Z

will check from desktop - the screenshot is unreadable on mobile :D

It shows the number of contributors for the week and a percentage based on that number vs. the total number of contributors. At least that's what I understand personally.

Oh that sounds bad, let me scope out some GS API routes and see if I can get you that data more easily! For now, leave them in and suppose it will work with at most, a secondary API call in the frontend, passing along the same date filters (so the interval only)

eryc-cc · 2022-08-25T18:55:47Z

@bdougie @pixelsbyeryc @0-vortex Quick question. Do we need the top part of the eChart from GitSense?

No, no need for this... People find it confusing 😛

eryc-cc

LGTM.

On mobile the labels are too close to each other. It'd be good to have a solution, BUT... I'd say ship it anyway.

It's probably best to spend our efforts on implementing another chat lib than to try modifying eCharts to our needs.

stories/molecules/card-line-chart.stories.tsx

github-actions

PR Compliance Checks Passed!

bdougie

There is an error in the deploy preview. We talked about it in slack.

I cleared the cache and re-deployed and it persists

chadstewart · 2022-08-27T12:34:00Z

There is an error in the deploy preview. We talked about it in slack.

I cleared the cache and re-deployed and it persists

That's my bad. Somehow the changes got reverted back to the previous v1/repos/list. I just merged beta into this branch and that fixed the issue.

bdougie

LGTM.

## [1.4.0-beta.1](v1.3.1-beta.2...v1.4.0-beta.1) (2022-08-31) ### 🍕 Features * Update Scatter Chart Legend ([#260](#260)) ([309ef62](309ef62))

github-actions · 2022-08-31T18:59:43Z

🎉 This PR is included in version 1.4.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.4.0](v1.3.0...v1.4.0) (2022-09-06) ### 🧑‍💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](#277)) ([4f1a771](4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](#286)) ([ada79d3](ada79d3)) * **footer:** swap out footer text ([#296](#296)) ([737df5b](737df5b)) * Update Scatter Chart Legend ([#260](#260)) ([309ef62](309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](#252)) ([7d6ae16](7d6ae16)), closes [#183](#183) [#289](#289) * Contributor card overlap on smaller devices ([#298](#298)) ([777f6ba](777f6ba)), closes [#290](#290) * correct netlify build supabase redirect url ([#283](#283)) ([0b2b80a](0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](#299)) ([bce1f8e](bce1f8e)), closes [#292](#292) * Fixing issues with TopNav and Highlight Card ([#294](#294)) ([218f30d](218f30d)), closes [#287](#287) [#291](#291) * grammar for header description ([#279](#279)) ([a019912](a019912))

## [1.4.0-beta.1](open-sauced/app@v1.3.1-beta.2...v1.4.0-beta.1) (2022-08-31) ### 🍕 Features * Update Scatter Chart Legend ([#260](open-sauced/app#260)) ([309ef62](open-sauced/app@309ef62))

## [1.4.0](open-sauced/app@v1.3.0...v1.4.0) (2022-09-06) ### 🧑‍💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](open-sauced/app#277)) ([4f1a771](open-sauced/app@4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](open-sauced/app#286)) ([ada79d3](open-sauced/app@ada79d3)) * **footer:** swap out footer text ([#296](open-sauced/app#296)) ([737df5b](open-sauced/app@737df5b)) * Update Scatter Chart Legend ([#260](open-sauced/app#260)) ([309ef62](open-sauced/app@309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](open-sauced/app#252)) ([7d6ae16](open-sauced/app@7d6ae16)), closes [#183](open-sauced/app#183) [#289](open-sauced/app#289) * Contributor card overlap on smaller devices ([#298](open-sauced/app#298)) ([777f6ba](open-sauced/app@777f6ba)), closes [#290](open-sauced/app#290) * correct netlify build supabase redirect url ([#283](open-sauced/app#283)) ([0b2b80a](open-sauced/app@0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](open-sauced/app#299)) ([bce1f8e](open-sauced/app@bce1f8e)), closes [#292](open-sauced/app#292) * Fixing issues with TopNav and Highlight Card ([#294](open-sauced/app#294)) ([218f30d](open-sauced/app@218f30d)), closes [#287](open-sauced/app#287) [#291](open-sauced/app#291) * grammar for header description ([#279](open-sauced/app#279)) ([a019912](open-sauced/app@a019912))

Initial commit for updating Scatter Chart Legend.

eb95fda

chadstewart added 2 commits August 25, 2022 10:12

Making some progress on setting up the axis.

3399dab

Making a bit more progress on the labels.

8f0b9ad

Doing more work on the eChart legends.

81cc3fa

Updated naming of scatter chart as it was no longer generic.

aa01d36

chadstewart requested review from 0-vortex, bdougie and eryc-cc August 25, 2022 21:12

chadstewart marked this pull request as ready for review August 25, 2022 21:12

chadstewart added the needs review PRs that need review from core engineering team label Aug 25, 2022

eryc-cc approved these changes Aug 25, 2022

View reviewed changes

stories/molecules/card-line-chart.stories.tsx Show resolved Hide resolved

eryc-cc assigned chadstewart Aug 25, 2022

eryc-cc added this to the Hacktoberfest Ready - Week 34 milestone Aug 25, 2022

Merge branch 'beta' into 101-update-scatter-chart-legend

3d491ae

github-actions bot reviewed Aug 26, 2022

View reviewed changes

bdougie requested changes Aug 27, 2022

View reviewed changes

bdougie added requested changes and removed needs review PRs that need review from core engineering team labels Aug 27, 2022

Merge branch 'beta' into 101-update-scatter-chart-legend

09e6c78

chadstewart requested a review from bdougie August 27, 2022 12:34

chadstewart removed the requested changes label Aug 27, 2022

chadstewart added the needs review PRs that need review from core engineering team label Aug 27, 2022

bdougie approved these changes Aug 31, 2022

View reviewed changes

bdougie added ready-to-merge and removed needs review PRs that need review from core engineering team labels Aug 31, 2022

chadstewart merged commit 309ef62 into beta Aug 31, 2022

chadstewart deleted the 101-update-scatter-chart-legend branch August 31, 2022 18:55

github-actions bot added the released on @beta label Aug 31, 2022

bdougie unassigned chadstewart Sep 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update Scatter Chart Legend #260

feat: Update Scatter Chart Legend #260

chadstewart commented Aug 24, 2022 •

edited

Loading

netlify bot commented Aug 24, 2022 •

edited

Loading

netlify bot commented Aug 24, 2022 •

edited

Loading

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

0-vortex commented Aug 25, 2022

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

eryc-cc commented Aug 25, 2022

eryc-cc left a comment

github-actions bot left a comment •

edited

Loading

bdougie left a comment •

edited

Loading

chadstewart commented Aug 27, 2022

bdougie left a comment

github-actions bot commented Aug 31, 2022

feat: Update Scatter Chart Legend #260

feat: Update Scatter Chart Legend #260

Conversation

chadstewart commented Aug 24, 2022 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Aug 24, 2022 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Aug 24, 2022 • edited Loading

✅ Deploy Preview for oss-insights ready!

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

0-vortex commented Aug 25, 2022

chadstewart commented Aug 25, 2022

0-vortex commented Aug 25, 2022

eryc-cc commented Aug 25, 2022

eryc-cc left a comment

Choose a reason for hiding this comment

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

chadstewart commented Aug 27, 2022

bdougie left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 31, 2022

chadstewart commented Aug 24, 2022 •

edited

Loading

netlify bot commented Aug 24, 2022 •

edited

Loading

netlify bot commented Aug 24, 2022 •

edited

Loading

github-actions bot left a comment •

edited

Loading

bdougie left a comment •

edited

Loading