Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Filter dropdown can only be closed by clicking on the filter button #292

Closed
3 of 6 tasks
Tracked by #295
chadstewart opened this issue Sep 2, 2022 · 1 comment · Fixed by #299
Closed
3 of 6 tasks
Tracked by #295

[Bug] Filter dropdown can only be closed by clicking on the filter button #292

chadstewart opened this issue Sep 2, 2022 · 1 comment · Fixed by #299
Assignees
@OgDev-01
Labels
🐛 bug Something isn't working low-priority 👀 needs triage released on @beta

Comments

@chadstewart
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

Once you click on the 'Filter +' dropdown menu, you cannot exit unless you specifically click on the 'Filter +' menu again. We should change this to "exit by clicking anywhere outside dropdown". I tried exiting upon clicking by clicking outside the box as usual but took me a few seconds to realize i couldn't exit unless i specifically clicked on the Add Filter+ menu. Even if you click on different pages within the site, the filter + still won't exit and will continue staying open blocking view.

Screen Shot 2022-09-01 at 12 22 13 PM

Screen Shot 2022-09-01 at 12 22 18 PM

Screen Shot 2022-09-01 at 11 45 17 AM

Steps to reproduce

Describe how to reproduce the behavior.

  1. Click on 'Filter +' button.
  2. Click on any other part of the site outside of 'Filter +' button or Filter Options dropdown.

Environment

Select the places where the issue can be reproduced (that you know of).

  • Local
  • Testing
  • Development
  • Production

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@bdougie bdougie mentioned this issue Sep 3, 2022
Closed
7 tasks
@OgDev-01 OgDev-01 self-assigned this Sep 5, 2022
@OgDev-01 OgDev-01 mentioned this issue Sep 5, 2022
Merged
19 tasks
@bdougie bdougie closed this as completed in bce1f8e Sep 6, 2022
github-actions bot pushed a commit that referenced this issue Sep 6, 2022
@OgDev-01 @open-sauced
chore(patch): release 1.4.0-beta.7 on beta channel [skip ci]
0e6a1d7 
## [1.4.0-beta.7](v1.4.0-beta.6...v1.4.0-beta.7) (2022-09-06)

### 🐛 Bug Fixes

* Filter dropdown can only be closed by clicking on the filter button ([#299](#299)) ([bce1f8e](bce1f8e)), closes [#292](#292)
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

🎉 This issue has been resolved in version 1.4.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 6, 2022
@bdougie @open-sauced
chore(minor): release 1.4.0 [skip ci]
01b2b2a 
## [1.4.0](v1.3.0...v1.4.0) (2022-09-06)

### 🧑‍💻 Code Refactoring

* Add types to useRepositoriesList hook ([#277](#277)) ([4f1a771](4f1a771))

### 🍕 Features

* Add download CSV funtionality to Reports page ([#286](#286)) ([ada79d3](ada79d3))
* **footer:** swap out footer text ([#296](#296)) ([737df5b](737df5b))
* Update Scatter Chart Legend ([#260](#260)) ([309ef62](309ef62))

### 🐛 Bug Fixes

* Add background to selectable tr table ([#252](#252)) ([7d6ae16](7d6ae16)), closes [#183](#183) [#289](#289)
* Contributor card overlap on smaller devices ([#298](#298)) ([777f6ba](777f6ba)), closes [#290](#290)
* correct netlify build supabase redirect url ([#283](#283)) ([0b2b80a](0b2b80a))
* Filter dropdown can only be closed by clicking on the filter button ([#299](#299)) ([bce1f8e](bce1f8e)), closes [#292](#292)
* Fixing issues with TopNav and Highlight Card ([#294](#294)) ([218f30d](218f30d)), closes [#287](#287) [#291](#291)
* grammar for header description ([#279](#279)) ([a019912](a019912))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(patch): release 1.4.0-beta.7 on beta channel [skip ci]
3650831 
## [1.4.0-beta.7](open-sauced/app@v1.4.0-beta.6...v1.4.0-beta.7) (2022-09-06)

### 🐛 Bug Fixes

* Filter dropdown can only be closed by clicking on the filter button ([#299](open-sauced/app#299)) ([bce1f8e](open-sauced/app@bce1f8e)), closes [#292](open-sauced/app#292)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.4.0 [skip ci]
8f5ee67 
## [1.4.0](open-sauced/app@v1.3.0...v1.4.0) (2022-09-06)

### 🧑‍💻 Code Refactoring

* Add types to useRepositoriesList hook ([#277](open-sauced/app#277)) ([4f1a771](open-sauced/app@4f1a771))

### 🍕 Features

* Add download CSV funtionality to Reports page ([#286](open-sauced/app#286)) ([ada79d3](open-sauced/app@ada79d3))
* **footer:** swap out footer text ([#296](open-sauced/app#296)) ([737df5b](open-sauced/app@737df5b))
* Update Scatter Chart Legend ([#260](open-sauced/app#260)) ([309ef62](open-sauced/app@309ef62))

### 🐛 Bug Fixes

* Add background to selectable tr table ([#252](open-sauced/app#252)) ([7d6ae16](open-sauced/app@7d6ae16)), closes [#183](open-sauced/app#183) [#289](open-sauced/app#289)
* Contributor card overlap on smaller devices ([#298](open-sauced/app#298)) ([777f6ba](open-sauced/app@777f6ba)), closes [#290](open-sauced/app#290)
* correct netlify build supabase redirect url ([#283](open-sauced/app#283)) ([0b2b80a](open-sauced/app@0b2b80a))
* Filter dropdown can only be closed by clicking on the filter button ([#299](open-sauced/app#299)) ([bce1f8e](open-sauced/app@bce1f8e)), closes [#292](open-sauced/app#292)
* Fixing issues with TopNav and Highlight Card ([#294](open-sauced/app#294)) ([218f30d](open-sauced/app@218f30d)), closes [#287](open-sauced/app#287) [#291](open-sauced/app#291)
* grammar for header description ([#279](open-sauced/app#279)) ([a019912](open-sauced/app@a019912))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OgDev-01 OgDev-01

Labels
🐛 bug Something isn't working low-priority 👀 needs triage released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Filter dropdown can only be closed by clicking on the filter button open-sauced/app
2 participants
@chadstewart @OgDev-01