feat: Add download CSV funtionality to Reports page #286

chadstewart · 2022-09-01T16:26:16Z

What type of PR is this? (check all applicable)

Description

This PR adds the feature of downloading CSVs from the reports page.

Details:

Added the filters to the filter options dropdown
Added the npm package react.csv to project and it handles generating a React component that allows you to download a csv.
Use a callback to get the selected filter and create the report object that will be passed to report history.
Currently we just use the useRepositoriesList hook to get some data to simulate. The intention in the future would be to have a function that'll use the correct endpoint and get data from there.
All the reports are currently stored in localstorage.
Made some CSS changes to fix issue with being displayed in mobile screens up to 375px. Current date being a potentially long string breaks design at 320px.

Related Tickets & Documents

Fixes #284
Fixes #288

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2022-09-01T16:26:22Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`f275796`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63124987a028f2000929b657
😎 Deploy Preview	https://deploy-preview-286--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-09-01T16:26:29Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`f275796`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63124987c3daac0009fece7b
😎 Deploy Preview	https://deploy-preview-286--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…face.

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

npm-shrinkwrap.json
package.json

0-vortex

Code LGTM! 👍

Regarding CSV generation, most likely that will happen on the backend with https://csv.js.org - the way that library works it's likely reusable across endpoints if you feel like doing a refactor! 🍕

chadstewart · 2022-09-02T20:35:58Z

Code LGTM! +1

Regarding CSV generation, most likely that will happen on the backend with https://csv.js.org - the way that library works it's likely reusable across endpoints if you feel like doing a refactor! pizza

So honestly, a lot of this work I view as a temporary solution until we can get a more back-end focused solution up and running. Really just here to at least have the functionality in some form.

bdougie

This will definitely need to be a limited feature (paid) and may even need to limit which data is downloadable.

Functional works though

## [1.4.0-beta.3](v1.4.0-beta.2...v1.4.0-beta.3) (2022-09-03) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](#286)) ([ada79d3](ada79d3))

github-actions · 2022-09-03T01:01:05Z

🎉 This PR is included in version 1.4.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.4.0](v1.3.0...v1.4.0) (2022-09-06) ### 🧑‍💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](#277)) ([4f1a771](4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](#286)) ([ada79d3](ada79d3)) * **footer:** swap out footer text ([#296](#296)) ([737df5b](737df5b)) * Update Scatter Chart Legend ([#260](#260)) ([309ef62](309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](#252)) ([7d6ae16](7d6ae16)), closes [#183](#183) [#289](#289) * Contributor card overlap on smaller devices ([#298](#298)) ([777f6ba](777f6ba)), closes [#290](#290) * correct netlify build supabase redirect url ([#283](#283)) ([0b2b80a](0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](#299)) ([bce1f8e](bce1f8e)), closes [#292](#292) * Fixing issues with TopNav and Highlight Card ([#294](#294)) ([218f30d](218f30d)), closes [#287](#287) [#291](#291) * grammar for header description ([#279](#279)) ([a019912](a019912))

## [1.4.0-beta.3](open-sauced/app@v1.4.0-beta.2...v1.4.0-beta.3) (2022-09-03) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](open-sauced/app#286)) ([ada79d3](open-sauced/app@ada79d3))

## [1.4.0](open-sauced/app@v1.3.0...v1.4.0) (2022-09-06) ### 🧑‍💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](open-sauced/app#277)) ([4f1a771](open-sauced/app@4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](open-sauced/app#286)) ([ada79d3](open-sauced/app@ada79d3)) * **footer:** swap out footer text ([#296](open-sauced/app#296)) ([737df5b](open-sauced/app@737df5b)) * Update Scatter Chart Legend ([#260](open-sauced/app#260)) ([309ef62](open-sauced/app@309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](open-sauced/app#252)) ([7d6ae16](open-sauced/app@7d6ae16)), closes [#183](open-sauced/app#183) [#289](open-sauced/app#289) * Contributor card overlap on smaller devices ([#298](open-sauced/app#298)) ([777f6ba](open-sauced/app@777f6ba)), closes [#290](open-sauced/app#290) * correct netlify build supabase redirect url ([#283](open-sauced/app#283)) ([0b2b80a](open-sauced/app@0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](open-sauced/app#299)) ([bce1f8e](open-sauced/app@bce1f8e)), closes [#292](open-sauced/app#292) * Fixing issues with TopNav and Highlight Card ([#294](open-sauced/app#294)) ([218f30d](open-sauced/app@218f30d)), closes [#287](open-sauced/app#287) [#291](open-sauced/app#291) * grammar for header description ([#279](open-sauced/app#279)) ([a019912](open-sauced/app@a019912))

Initial commit to add download csv functionality from reports.

cff1060

chadstewart added 9 commits September 1, 2022 12:12

Added filter options to reports filter options dropdown.

b4431e6

Added react-csv to project.

40445c5

Merge branch 'beta' into 284-repo-list-response-to-csv

25992e2

Added logic to generate a report.

2a15d55

Set up error handling for select reports.

b30f9f6

Successfully added download CSV functionality to reports.

dd1b84e

Added proper date to reports.

c5be575

Added current state of reports to localstorage.

226017f

Updated report history story to correspond to changes in report inter…

e173e8d

…face.

chadstewart marked this pull request as ready for review September 2, 2022 13:25

chadstewart added the needs review PRs that need review from core engineering team label Sep 2, 2022

chadstewart requested review from 0-vortex and bdougie September 2, 2022 13:26

Adding PRs text to contributors profile.

b511bf9

github-actions bot reviewed Sep 2, 2022

View reviewed changes

Adding functionality to display s in PRs when totalPRs is not 1.

226d42d

chadstewart removed the needs review PRs that need review from core engineering team label Sep 2, 2022

chadstewart removed request for 0-vortex and bdougie September 2, 2022 15:43

chadstewart marked this pull request as draft September 2, 2022 15:43

Fixed mobile issue where design broke down in mobile up to 375px width.

f275796

chadstewart requested review from eryc-cc, 0-vortex and bdougie September 2, 2022 18:23

chadstewart marked this pull request as ready for review September 2, 2022 18:23

chadstewart added the needs review PRs that need review from core engineering team label Sep 2, 2022

0-vortex approved these changes Sep 2, 2022

View reviewed changes

bdougie approved these changes Sep 2, 2022

View reviewed changes

chadstewart merged commit ada79d3 into beta Sep 3, 2022

chadstewart deleted the 284-repo-list-response-to-csv branch September 3, 2022 00:58

github-actions bot added the released on @beta label Sep 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add download CSV funtionality to Reports page #286

feat: Add download CSV funtionality to Reports page #286

chadstewart commented Sep 1, 2022 •

edited

Loading

netlify bot commented Sep 1, 2022 •

edited

Loading

netlify bot commented Sep 1, 2022 •

edited

Loading

github-actions bot left a comment

0-vortex left a comment

chadstewart commented Sep 2, 2022

bdougie left a comment

github-actions bot commented Sep 3, 2022

feat: Add download CSV funtionality to Reports page #286

feat: Add download CSV funtionality to Reports page #286

Conversation

chadstewart commented Sep 1, 2022 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Sep 1, 2022 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Sep 1, 2022 • edited Loading

✅ Deploy Preview for oss-insights ready!

github-actions bot left a comment

Choose a reason for hiding this comment

PR Compliance Checks

Watched Files

0-vortex left a comment

Choose a reason for hiding this comment

chadstewart commented Sep 2, 2022

bdougie left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 3, 2022

chadstewart commented Sep 1, 2022 •

edited

Loading

netlify bot commented Sep 1, 2022 •

edited

Loading

netlify bot commented Sep 1, 2022 •

edited

Loading