-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix 'Connect with GitHub' button padding #287
Labels
Comments
19 tasks
bdougie
pushed a commit
that referenced
this issue
Sep 5, 2022
🎉 This issue has been resolved in version 1.4.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this issue
Sep 6, 2022
## [1.4.0](v1.3.0...v1.4.0) (2022-09-06) ### 🧑💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](#277)) ([4f1a771](4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](#286)) ([ada79d3](ada79d3)) * **footer:** swap out footer text ([#296](#296)) ([737df5b](737df5b)) * Update Scatter Chart Legend ([#260](#260)) ([309ef62](309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](#252)) ([7d6ae16](7d6ae16)), closes [#183](#183) [#289](#289) * Contributor card overlap on smaller devices ([#298](#298)) ([777f6ba](777f6ba)), closes [#290](#290) * correct netlify build supabase redirect url ([#283](#283)) ([0b2b80a](0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](#299)) ([bce1f8e](bce1f8e)), closes [#292](#292) * Fixing issues with TopNav and Highlight Card ([#294](#294)) ([218f30d](218f30d)), closes [#287](#287) [#291](#291) * grammar for header description ([#279](#279)) ([a019912](a019912))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this issue
Aug 17, 2023
## [1.4.0-beta.5](open-sauced/app@v1.4.0-beta.4...v1.4.0-beta.5) (2022-09-05) ### 🐛 Bug Fixes * Fixing issues with TopNav and Highlight Card ([#294](open-sauced/app#294)) ([218f30d](open-sauced/app@218f30d)), closes [#287](open-sauced/app#287) [#291](open-sauced/app#291)
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this issue
Aug 17, 2023
## [1.4.0](open-sauced/app@v1.3.0...v1.4.0) (2022-09-06) ### 🧑💻 Code Refactoring * Add types to useRepositoriesList hook ([#277](open-sauced/app#277)) ([4f1a771](open-sauced/app@4f1a771)) ### 🍕 Features * Add download CSV funtionality to Reports page ([#286](open-sauced/app#286)) ([ada79d3](open-sauced/app@ada79d3)) * **footer:** swap out footer text ([#296](open-sauced/app#296)) ([737df5b](open-sauced/app@737df5b)) * Update Scatter Chart Legend ([#260](open-sauced/app#260)) ([309ef62](open-sauced/app@309ef62)) ### 🐛 Bug Fixes * Add background to selectable tr table ([#252](open-sauced/app#252)) ([7d6ae16](open-sauced/app@7d6ae16)), closes [#183](open-sauced/app#183) [#289](open-sauced/app#289) * Contributor card overlap on smaller devices ([#298](open-sauced/app#298)) ([777f6ba](open-sauced/app@777f6ba)), closes [#290](open-sauced/app#290) * correct netlify build supabase redirect url ([#283](open-sauced/app#283)) ([0b2b80a](open-sauced/app@0b2b80a)) * Filter dropdown can only be closed by clicking on the filter button ([#299](open-sauced/app#299)) ([bce1f8e](open-sauced/app@bce1f8e)), closes [#292](open-sauced/app#292) * Fixing issues with TopNav and Highlight Card ([#294](open-sauced/app#294)) ([218f30d](open-sauced/app@218f30d)), closes [#287](open-sauced/app#287) [#291](open-sauced/app#291) * grammar for header description ([#279](open-sauced/app#279)) ([a019912](open-sauced/app@a019912))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A clear and concise description of what the bug is.
The 'Connect With GitHub' button's padding becomes non-existent once the window gets smaller in size. In mobile/tablet view, it is like this permanently. Screenshot of both mobile and window attached. This might be due to the PNG of our slice having more dead-space in its format so in reality, both paddings are even but due to the dead space in the png, it looks uneven. If this is the case, we would need to correct this and crop the PNG more accurately.
Mobile:
![button](https://user-images.githubusercontent.com/11777161/188179691-d283bdbd-b888-4347-a6b0-c76aac395c68.jpg)
![button-window](https://user-images.githubusercontent.com/11777161/188179700-4174034e-1dc5-451d-b612-27a03f842e64.jpg)
Window:
Steps to reproduce
Describe how to reproduce the behavior.
Environment
Select the places where the issue can be reproduced (that you know of).
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.
Contributing Docs
If you plan on contributing code please read - Contribution Guide
The text was updated successfully, but these errors were encountered: