Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use direct OpenGraph Image URLs on repository insight pages #3256

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

brandonroberts
Copy link
Contributor

Description

  • Offloads the OpenGraph Image URL from the getServersideProps for repository insights
  • Should help with Netlify function timeouts by making one less API request in the function

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 9853649
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/662a99cf14c2d90008c44a68
😎 Deploy Preview https://deploy-preview-3256--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 9853649
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/662a99cfa3096e0008acd1ca
😎 Deploy Preview https://deploy-preview-3256--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts requested a review from a team April 25, 2024 17:52
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonroberts brandonroberts merged commit 0578019 into beta Apr 25, 2024
13 checks passed
@brandonroberts brandonroberts deleted the fix-ogimage-repo-insights branch April 25, 2024 19:16
open-sauced bot pushed a commit that referenced this pull request Apr 25, 2024
## [2.22.0-beta.2](v2.22.0-beta.1...v2.22.0-beta.2) (2024-04-25)

### 🐛 Bug Fixes

* use direct OpenGraph Image URLs on repository insight pages ([#3256](#3256)) ([0578019](0578019))
open-sauced bot pushed a commit that referenced this pull request Apr 30, 2024
## [2.22.0](v2.21.0...v2.22.0) (2024-04-30)

### ✅ Tests

* speed up server for playwright tests on CI ([#3274](#3274)) ([dd62ef4](dd62ef4))

### 🐛 Bug Fixes

* capture repo page share as unique event with repo name as metadata ([#3284](#3284)) ([83cb0de](83cb0de))
* fixed layout issues in StarSearch ([#3257](#3257)) ([ce07b8c](ce07b8c))
* now small screens show follow/unfollow on user profile ([#3260](#3260)) ([6a8a421](6a8a421))
* now StarSearch input is not covered by vertical suggestions on small screens ([#3265](#3265)) ([1624ea8](1624ea8))
* now StarSearch link is in sidebar for smaller screens ([#3263](#3263)) ([71cd5b9](71cd5b9))
* remove filter prefetch and additional filters when searching by repository ([#3247](#3247)) ([59eb8cc](59eb8cc))
* removed connection tab on user profile page ([#3275](#3275)) ([cbd1382](cbd1382))
* Update README with current OpenSauced logo ([#3255](#3255)) ([2252900](2252900))
* use direct OpenGraph Image URLs on repository insight pages ([#3256](#3256)) ([0578019](0578019))

### 🍕 Features

* implement PR and issue devstats to repo pages ([#3253](#3253)) ([caa7eea](caa7eea))
* now you can share the StarSearch waitlist on socials ([#3285](#3285)) ([6732853](6732853))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants