Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now StarSearch input is not covered by vertical suggestions on small screens #3265

Merged
merged 5 commits into from Apr 26, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Apr 25, 2024

Description

Now StarSearch input is not covered by vertical suggestions on small screens

Related Tickets & Documents

Relates to #3258

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-04-25 at 19 50 49

After

CleanShot 2024-04-25 at 19 50 09

Steps to QA

  1. Go to StarSearch, /star-search
  2. Resize the screen or use a smaller device.
  3. Notice the vertical suggestions no longer cover the prompt input.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 62cbb82
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/662b4969c34f4b000880b216
😎 Deploy Preview https://deploy-preview-3265--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 62cbb82
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/662b496981dfe60008f99c71
😎 Deploy Preview https://deploy-preview-3265--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team April 25, 2024 23:49
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approved this in a self driving car, on my way to an AI event. Very surreal moment.

image

@nickytonline nickytonline merged commit 1624ea8 into beta Apr 26, 2024
12 of 13 checks passed
@nickytonline nickytonline deleted the nickytonline/fix-input-overalpping branch April 26, 2024 10:32
open-sauced bot pushed a commit that referenced this pull request Apr 26, 2024
## [2.22.0-beta.6](v2.22.0-beta.5...v2.22.0-beta.6) (2024-04-26)

### 🐛 Bug Fixes

* now StarSearch input is not covered by vertical suggestions on small screens ([#3265](#3265)) ([1624ea8](1624ea8))
open-sauced bot pushed a commit that referenced this pull request Apr 30, 2024
## [2.22.0](v2.21.0...v2.22.0) (2024-04-30)

### ✅ Tests

* speed up server for playwright tests on CI ([#3274](#3274)) ([dd62ef4](dd62ef4))

### 🐛 Bug Fixes

* capture repo page share as unique event with repo name as metadata ([#3284](#3284)) ([83cb0de](83cb0de))
* fixed layout issues in StarSearch ([#3257](#3257)) ([ce07b8c](ce07b8c))
* now small screens show follow/unfollow on user profile ([#3260](#3260)) ([6a8a421](6a8a421))
* now StarSearch input is not covered by vertical suggestions on small screens ([#3265](#3265)) ([1624ea8](1624ea8))
* now StarSearch link is in sidebar for smaller screens ([#3263](#3263)) ([71cd5b9](71cd5b9))
* remove filter prefetch and additional filters when searching by repository ([#3247](#3247)) ([59eb8cc](59eb8cc))
* removed connection tab on user profile page ([#3275](#3275)) ([cbd1382](cbd1382))
* Update README with current OpenSauced logo ([#3255](#3255)) ([2252900](2252900))
* use direct OpenGraph Image URLs on repository insight pages ([#3256](#3256)) ([0578019](0578019))

### 🍕 Features

* implement PR and issue devstats to repo pages ([#3253](#3253)) ([caa7eea](caa7eea))
* now you can share the StarSearch waitlist on socials ([#3285](#3285)) ([6732853](6732853))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants