Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now small screens show follow/unfollow on user profile #3260

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Apr 25, 2024

Description

Now small screens show follow/unfollow on user profile. There used to be an icon for this, but it looks like we only use the three dot menu now. Regardless, follow/unfollow is back on small screens.

Related Tickets & Documents

Fixes #3261

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-04-25 at 17 41 40

After

CleanShot 2024-04-25 at 17 38 58

Steps to QA

  1. Go to a user profile on a small screen for someone you're not following.
  2. Click the three dots menu and click follow.
  3. You can now follow them.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 93bc0a6
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/662baf6430a00f0008584edd
😎 Deploy Preview https://deploy-preview-3260--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 93bc0a6
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/662baf64730bfb0008b2f161
😎 Deploy Preview https://deploy-preview-3260--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline merged commit 6a8a421 into beta Apr 26, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/follow-on-small-screens branch April 26, 2024 13:53
open-sauced bot pushed a commit that referenced this pull request Apr 29, 2024
## [2.22.0-beta.7](v2.22.0-beta.6...v2.22.0-beta.7) (2024-04-29)

### 🐛 Bug Fixes

* now small screens show follow/unfollow on user profile ([#3260](#3260)) ([6a8a421](6a8a421))
open-sauced bot pushed a commit that referenced this pull request Apr 30, 2024
## [2.22.0](v2.21.0...v2.22.0) (2024-04-30)

### ✅ Tests

* speed up server for playwright tests on CI ([#3274](#3274)) ([dd62ef4](dd62ef4))

### 🐛 Bug Fixes

* capture repo page share as unique event with repo name as metadata ([#3284](#3284)) ([83cb0de](83cb0de))
* fixed layout issues in StarSearch ([#3257](#3257)) ([ce07b8c](ce07b8c))
* now small screens show follow/unfollow on user profile ([#3260](#3260)) ([6a8a421](6a8a421))
* now StarSearch input is not covered by vertical suggestions on small screens ([#3265](#3265)) ([1624ea8](1624ea8))
* now StarSearch link is in sidebar for smaller screens ([#3263](#3263)) ([71cd5b9](71cd5b9))
* remove filter prefetch and additional filters when searching by repository ([#3247](#3247)) ([59eb8cc](59eb8cc))
* removed connection tab on user profile page ([#3275](#3275)) ([cbd1382](cbd1382))
* Update README with current OpenSauced logo ([#3255](#3255)) ([2252900](2252900))
* use direct OpenGraph Image URLs on repository insight pages ([#3256](#3256)) ([0578019](0578019))

### 🍕 Features

* implement PR and issue devstats to repo pages ([#3253](#3253)) ([caa7eea](caa7eea))
* now you can share the StarSearch waitlist on socials ([#3285](#3285)) ([6732853](6732853))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't follow someone from their profile on small screens
3 participants