feat: Lottery Factor chart for Repo pages #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'll review it further, but just collecting on feedback from @bdougie -- Let's add an explainer tooltip to the title to explain what lottery factor is |
|
Note for @jpmcb, we talked IRL. But we should filter out bots on the end point. |
|
One small comment is that if there hasn't been any commits for the time range selected, it breaks: I'm designing both an empty state and the tooltip rn so we can work them in, put the chart in the layout and ship :) |
nickytonline
requested changes
May 10, 2024
nickytonline
requested changes
May 10, 2024
Co-authored-by: Nick Taylor <nick@nickyt.co>
|
@zeucapua here's the empty state for this chart as well: 
Image by itself: |
Can we add an empty state example to the Storybook stories as well? |
nickytonline
requested changes
May 13, 2024
There was a problem hiding this comment.
Thanks for making the updates @zeucapua.
One last thing. The loading state doesn't span the whole chart for contributor rows.
nickytonline
approved these changes
May 13, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
May 13, 2024
## [2.27.0-beta.1](v2.26.1-beta.1...v2.27.0-beta.1) (2024-05-13) ### 🍕 Features * Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e))
open-sauced bot
pushed a commit
that referenced
this pull request
May 15, 2024
## [2.27.0](v2.26.0...v2.27.0) (2024-05-15) ### 🍕 Features * Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3)) * Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e)) ### 🐛 Bug Fixes * now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4)) * now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048)) * temporarily returning for event: function_call in readable stream from StarSearch ([#3379](#3379)) ([f6f4b01](f6f4b01)) * title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a new
LotteryFactorChartthat show the repository and top 4 contributors' lotto factor with a summary and segmented bar chart to see contributor distribution.Related Tickets & Documents
Closes #3341
Closes #3365
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-05-10.at.4.27.59.PM.mov
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?