Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now opening workspace dropdown puts focus on search input #3364

Merged
merged 3 commits into from May 13, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 10, 2024

Description

Now when you open the workspace dropdown, focus is given to the search input making it more accessible and less annoying to use.

Related Tickets & Documents

Fixes #3362

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-05-10 at 10 33 48

After

CleanShot 2024-05-10 at 10 32 34

Steps to QA

  1. In the app sidebar, click on the workspace dropdown.
  2. Notice the search items input automatically has focus.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 10, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 1b44f9d
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66427efae3a5570007353a40
😎 Deploy Preview https://deploy-preview-3364--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 1b44f9d
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66427efaeb3e360007f09383
😎 Deploy Preview https://deploy-preview-3364--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team May 10, 2024 14:35
@isabensusan isabensusan self-requested a review May 13, 2024 20:59
Copy link
Member

@isabensusan isabensusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect-mean-girls-gif

@nickytonline nickytonline merged commit bafa0e4 into beta May 13, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/workspace-dropdown-focus-bug branch May 13, 2024 21:08
open-sauced bot pushed a commit that referenced this pull request May 13, 2024
## [2.27.0-beta.2](v2.27.0-beta.1...v2.27.0-beta.2) (2024-05-13)

### 🐛 Bug Fixes

* now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4))
open-sauced bot pushed a commit that referenced this pull request May 15, 2024
## [2.27.0](v2.26.0...v2.27.0) (2024-05-15)

### 🍕 Features

* Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3))
* Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e))

### 🐛 Bug Fixes

* now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4))
* now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048))
* temporarily returning for event: function_call in readable stream from StarSearch ([#3379](#3379)) ([f6f4b01](f6f4b01))
* title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Opening Workspace dropdown does not put focus on input
3 participants