-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed padding between icon and text in UI #27
Conversation
β Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@bdougie please can you merge this? |
Please can you give this PR a descriptive title |
@dev-phantom thanks for your replay i made those changes, have a look |
Ok nice And I don't feel you need to add "tag" to the PR template as it already has "related tickets and documents" |
@dev-phantom i am really sorry, how about now!? |
No need to apologize |
@dev-phantom what about now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working with all the generated css will make it hard to do custom UI.
Per @Muniir1, the important is needed and we may consider building something custom if we would like customize the site further
@bdougie "Thank you for the insights! I understand the concern about using !important excessively and its potential impact on the custom UI. Considering the drawbacks, I agree that it would be best to explore other options and potentially build a custom solution to achieve the desired UI customizations. Additionally, I'll look into the possibility of contributing a fix or improvement to the 'docsify' project to address the issue more elegantly. Your input has been very helpful in guiding my approach. Thanks again!" |
@bdougie can you please check the changes that i just made and it works the same as the result before. |
The changes are great and work. I question the approach manually adding the ids. What happens when we add a new section? Or a new language? Does it make sense to modify the class-name instead? Also, does it make more sense to fix here in the theme? https://github.com/docsifyjs/docsify/blob/develop/src/themes/vue.styl |
@Muniir1 why in the section of the description is checked the test checkbox ??? |
Description
Fixed padding between icon and text in UI
Generated using OpenSauced.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #20
Mobile & Desktop Screenshots/Recordings
the problem
the result
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?