Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

build(npm): added dotnpm and loggable audit #1032

Closed
wants to merge 1 commit into from
Closed

build(npm): added dotnpm and loggable audit #1032

wants to merge 1 commit into from

Conversation

0-vortex
Copy link
Contributor

@0-vortex 0-vortex commented Jun 5, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

  • added repository npm configuration
  • disabled running audit on install
  • added audit for production dependencies

Related Tickets & Documents

Unblocks #1017

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@0-vortex
Copy link
Contributor Author

userconfig override from https://github.com/actions/setup-node/blob/5c355be17065acf11598c7a9bb47112fbcf2bbdc/src/authutil.ts#L54-L56 was essentailly causing us to run into npm/cli#3311 because of existing errors.

currently fixed and should not run into it anymore in the future

@0-vortex 0-vortex closed this Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0-vortex