Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sig-services): add security implications requirement #210

Merged
merged 1 commit into from
Jul 21, 2022
Merged

feat(sig-services): add security implications requirement #210

merged 1 commit into from
Jul 21, 2022

Conversation

SamoKopecky
Copy link
Member

Closes #108

@sesheta sesheta requested review from Shreyanand and tumido May 27, 2022 13:20
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2022
@SamoKopecky
Copy link
Member Author

/retest

@tumido
Copy link
Member

tumido commented Jun 9, 2022

I've included some small changes I would make to the wording.. overall I like it 🙂

@SamoKopecky
Add security implications requirement
a172a0a 
Signed-off-by: SamoKopecky <skopecky@redhat.com>
@SamoKopecky
Copy link
Member Author

Thanks for the feedback, changes are applied.

@SamoKopecky SamoKopecky requested a review from tumido June 9, 2022 14:13
tumido
tumido approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2022
Shreyanand
Shreyanand approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sesheta
Copy link
Contributor

sesheta commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shreyanand, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit b3324a1 into open-services-group:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@Shreyanand Shreyanand Shreyanand approved these changes

Assignees

@tumido tumido

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIG Services][Guideline] Explain the security implications
4 participants
@SamoKopecky @tumido @sesheta @Shreyanand