Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sig-services): Add customer zero guideline #230

Merged
merged 1 commit into from
Aug 1, 2022
Merged

feat(sig-services): Add customer zero guideline #230

merged 1 commit into from
Aug 1, 2022

Conversation

mimotej
Copy link
Member

@mimotej mimotej commented Jun 29, 2022

Resolves #159

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2022
@SamoKopecky
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
Shreyanand
Shreyanand reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, otherwise /lgtm

sig-services/service-requirements/customer-zero.md Outdated Show resolved Hide resolved
sig-services/service-requirements/customer-zero.md Outdated Show resolved Hide resolved
sig-services/service-requirements/customer-zero.md Outdated Show resolved Hide resolved
feat(sig-services): Add customer zero guideline
d8b128e 
Signed-off-by: Michal Drla <mdrla@redhat.com>
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@mimotej mimotej requested a review from Shreyanand July 25, 2022 08:26
Shreyanand
Shreyanand approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@sesheta
Copy link
Contributor

sesheta commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shreyanand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@sesheta sesheta merged commit e6ab3ba into open-services-group:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shreyanand Shreyanand Shreyanand approved these changes

@tumido tumido Awaiting requested review from tumido

Assignees

@Shreyanand Shreyanand

@SamoKopecky SamoKopecky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIG Services][Guideline] Have a customer 0
4 participants
@mimotej @SamoKopecky @sesheta @Shreyanand