Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redefined(_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES) warning #864

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

hjmjohnson
Copy link
Contributor

@hjmjohnson hjmjohnson commented Jan 13, 2019

This is an update to PR #834 to resolve merge conflicts.

1) Improve travis build script for use outside travis.
   Allow the script used for CI builds to also be used
   locally in a similar manner to the CI use of the scrips

2) Add ctest compatible testing and CDASH support
   Report testing and building results to
   https://my.cdash.org/index.php?project=jsoncpp

   NOTE: The new ctest infrastructure is not yet robust on winodws
         Do no yet enable the new features for running test with ctest
         on windows platform.  The previous behaviors are maintainted,
         but enhance test reporting from windows is not yet supported.

3) Add a cmake coverage testing option
   Ensure that cmake builds on linux are tested.
   Ensure that code coverage is reported.

4) Move conditional environment checking into the matrix
   Avoid multiple places where conditional logic is used to
   change compiler behavior.  As more test environments are
   created fromt the travis.yml matrix, all settings should be
   obvious from that one location.

5) Tests with known regressions from the jsonchecker are suppressed
    Tests that are known to pass with jsoncpp more lenient
    syntax enforcement are exluded from tests in test/runjsontests.py
@hjmjohnson hjmjohnson force-pushed the terrycz126-master branch 2 times, most recently from 267a7e4 to 762b68c Compare January 13, 2019 00:26
@hjmjohnson
Copy link
Contributor Author

@terrycz126 This change was previously approved in #834. Minor merge conflict was addressed.

@hjmjohnson hjmjohnson merged commit 8b31c6f into open-source-parsers:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants