Add AsyncDrain #25
Merged
Add AsyncDrain #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| buffer = [] | ||
| completion {} | ||
| } | ||
| } |
|
You've got a thumbs up from me. But @paulofaria knows more about this stuff so let's wait for his thumbs up as well. I think we can merge this today since it's been neglected for so long. |
|
|
||
| stream.receive(upTo: 1024, timingOut: deadline) { [unowned self] in | ||
| do { | ||
| let chunk = try $0() |
There was a problem hiding this comment.
I would prefer to use getData here instead of $0.
|
@paulofaria @tannernelson I fixed some issues. When this is merged and released with next tag then I'm gonna resolve conflicts for open-swift/S4#52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding AsyncDrain that has similar apis to
Drain.And it is required for open-swift/S4#52
Please review this!