fuzzier json number equatable #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| private var uint: UInt? { | ||
| switch self { | ||
| case let .double(d) where d >= 0: | ||
| return UInt(d) |
There was a problem hiding this comment.
Doesn't this cut the floating point part of the number?
let d = 2.1
UInt(d) //2
There was a problem hiding this comment.
So if you'd be comparing UInt(2) and Double(2.1), it'd return true. That doesn't seem right
|
@czechboy0 totally right, just updated! |
|
Cool, just left one comment for something that I think should be fixed. Once that's done I'll merge, thanks @loganwright! (Even though it's not 100% correct (Int.max gets cut when converted to Double), but 99.99% might be good enough here, it definitely is easier to use) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One potential implementation of fuzzier json number equality. When creating a double, I don't know how to check if below Double max similar to others if someone has suggestions.