[8.0.1.0.0][hr_employee_birthday_list_reminder] #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 8.0 #199 +/- ##
==========================================
- Coverage 58.55% 58.12% -0.44%
==========================================
Files 257 258 +1
Lines 5298 5394 +96
==========================================
+ Hits 3102 3135 +33
- Misses 2196 2259 +63
Continue to review full report at Codecov.
|
andhit-r
requested changes
Mar 6, 2020
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "depends": [ | ||
| "web", |
Comment on lines
1
to
20
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * hr_employee_birthdate_from_home_address | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 8.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "Last-Translator: <>\n" | ||
| "Language-Team: \n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: \n" | ||
|
|
||
| #. module: hr_employee_birthdate_from_home_address | ||
| #: model:ir.model,name:hr_employee_birthdate_from_home_address.model_hr_employee | ||
| msgid "Employee" | ||
| msgstr "" | ||
|
|
| # Copyright 2020 OpenSynergy Indonesia | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import hr_birthday_list_reminder |
There was a problem hiding this comment.
Suggested change
| from . import hr_birthday_list_reminder | |
| from . import ( | |
| hr_birthday_list_reminder, | |
| ) |
| "mail", | ||
| "email_template", | ||
| "hr", | ||
| ], |
There was a problem hiding this comment.
Pakai python_depends karena menggunakan pandas
| <field name="manual_employee_ids" col="2" nolabel="1"/> | ||
| </group> | ||
| </page> | ||
| <page name="employee" string="Employee(s) List" groups="base.group_erp_manager"> |
There was a problem hiding this comment.
Suggested change
| <page name="employee" string="Employee(s) List" groups="base.group_erp_manager"> | |
| <page name="employee" string="Employee(s) List"> |
Comment on lines
128
to
129
| dt_now - pd.DateOffset( | ||
| days=date_start_offset) |
Comment on lines
132
to
133
| dt_now - pd.DateOffset( | ||
| months=date_start_offset) |
andhit-r
requested changes
Mar 8, 2020
There was a problem hiding this comment.
@mikevhe18 contoh kasus:
- Karyawan A ultah 09-03-1984
- Today 01-03-2020
- Start offset: 0 Days
- End offset: 30 Days
Kasus di atas harusnya masuk di dalam list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.